Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4580)

Unified Diff: base/timer/timer.h

Issue 136203009: Support auto-reload on errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Clean up nits Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/timer/timer.h
diff --git a/base/timer/timer.h b/base/timer/timer.h
index 71a7ae8888a3afd82be5419b24e4d0df22da2955..1e662a3dea71b599b2e3719746003d28ebd60fbf 100644
--- a/base/timer/timer.h
+++ b/base/timer/timer.h
@@ -82,7 +82,7 @@ class BASE_EXPORT Timer {
virtual ~Timer();
// Returns true if the timer is running (i.e., not stopped).
- bool IsRunning() const {
+ virtual bool IsRunning() const {
Randy Smith (Not in Mondays) 2014/02/13 18:47:40 I'd be a little surprised if this didn't get pushb
mmenke 2014/02/13 20:42:17 You don't seem to be making use of these changes a
Elly Fong-Jones 2014/02/25 19:19:52 Yeah, I did this while I was experimenting and for
return is_running_;
}
@@ -93,17 +93,17 @@ class BASE_EXPORT Timer {
// Start the timer to run at the given |delay| from now. If the timer is
// already running, it will be replaced to call the given |user_task|.
- void Start(const tracked_objects::Location& posted_from,
+ virtual void Start(const tracked_objects::Location& posted_from,
TimeDelta delay,
const base::Closure& user_task);
// Call this method to stop and cancel the timer. It is a no-op if the timer
// is not running.
- void Stop();
+ virtual void Stop();
// Call this method to reset the timer delay. The user_task_ must be set. If
// the timer is not running, this will start it by posting a task.
- void Reset();
+ virtual void Reset();
const base::Closure& user_task() const { return user_task_; }
const TimeTicks& desired_run_time() const { return desired_run_time_; }
« no previous file with comments | « no previous file | chrome/browser/chrome_content_browser_client.cc » ('j') | chrome/browser/chrome_content_browser_client.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698