chrome/renderer/net/mockable_one_shot_timer.h - Issue 136203009: Support auto-reload on errors.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/net/mockable_one_shot_timer.h

Issue 136203009: Support auto-reload on errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Fixes Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/renderer/chrome_content_renderer_client.cc ('K') | « chrome/renderer/chrome_content_renderer_client.cc ('k') | chrome/renderer/net/mockable_one_shot_timer.cc » ('j') | chrome/renderer/net/mockable_one_shot_timer.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_RENDERER_NET_MOCKABLE_ONE_SHOT_TIMER_H_

	6 #define CHROME_RENDERER_NET_MOCKABLE_ONE_SHOT_TIMER_H_

	7

	8 #include <base/callback.h>

	9 #include <base/timer/timer.h>

	10

	11 class MockableOneShotTimer {
	Randy Smith (Not in Mondays) 2014/02/06 16:47:16 It might be worthwhile tossing an email at whoever It might be worthwhile tossing an email at whoever wrote OneShotTimer to see if they'd mine you making it mockable directly. That would just (sic?) take adding three "virtual" keywords, right?
	12 public:

	13 MockableOneShotTimer();

	14 virtual ~MockableOneShotTimer();

	15 virtual void Start(const tracked_objects::Location& posted_from,

	16 base::TimeDelta delay,

	17 const base::Closure& user_task);
	mmenke 2014/02/05 23:31:43 Maybe just task? "user" seems ambiguous. Same fo Maybe just task? "user" seems ambiguous. Same for the MockOneShotTimer. Elly Fong-Jones 2014/02/10 21:42:06 Done. Show quoted text On 2014/02/05 23:31:43, mmenke wrote: > Maybe just task? "user" seems ambiguous. Same for the MockOneShotTimer. Done.
	18 virtual void Stop();

	19 virtual bool IsRunning() const;

	20 private:
	mmenke 2014/02/05 23:31:43 nit: Linebreak before private. nit: Linebreak before private. Elly Fong-Jones 2014/02/10 21:42:06 Done. Show quoted text On 2014/02/05 23:31:43, mmenke wrote: > nit: Linebreak before private. Done.
	21 void Fired();
	mmenke 2014/02/05 23:31:43 Blank line between methofs and values. Blank line between methofs and values. Elly Fong-Jones 2014/02/10 21:42:06 Done. Show quoted text On 2014/02/05 23:31:43, mmenke wrote: > Blank line between methofs and values. Done.
	22 base::OneShotTimer<MockableOneShotTimer> timer_;

	23 base::Closure user_task_;
	mmenke 2014/02/05 23:31:43 DISALLOW_COPY_AND_ASSIGN + relevant header? DISALLOW_COPY_AND_ASSIGN + relevant header? Elly Fong-Jones 2014/02/10 21:42:06 Done. Show quoted text On 2014/02/05 23:31:43, mmenke wrote: > DISALLOW_COPY_AND_ASSIGN + relevant header? Done.
	24 };

	25

	26 #endif // CHROME_RENDERER_NET_MOCKABLE_ONE_SHOT_TIMER_H_

OLD	NEW