Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1361993002: Update configure to look for README.md instead of README (Closed)

Created:
5 years, 2 months ago by Mark Mentovai
Modified:
5 years, 2 months ago
Reviewers:
Bons
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update configure to look for README.md instead of README This is required after daed3a43836e. configure won't run as-is, reported in https://codereview.chromium.org/1357773004/. R=andybons@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/94b1ccb51ff3ea45fc6f6226641f3d584f2190b0

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Makefile.in View 1 chunk +3 lines, -3 lines 1 comment Download
M configure View 1 chunk +1 line, -1 line 0 comments Download
M configure.ac View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Mentovai
5 years, 2 months ago (2015-09-23 14:35:32 UTC) #1
Bons
lgtm https://codereview.chromium.org/1361993002/diff/1/Makefile.in File Makefile.in (right): https://codereview.chromium.org/1361993002/diff/1/Makefile.in#newcode1886 Makefile.in:1886: + autotools/compile autotools/config.guess autotools/config.sub \ Guessing you meant ...
5 years, 2 months ago (2015-09-23 14:36:49 UTC) #2
Mark Mentovai
Yeah, I only edited configure.ac. Makefile.in and configure were auto-generated. The README in Makefile.in was ...
5 years, 2 months ago (2015-09-23 14:39:59 UTC) #3
Mark Mentovai
5 years, 2 months ago (2015-09-23 14:47:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
94b1ccb51ff3ea45fc6f6226641f3d584f2190b0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698