[swarming] Add isolate configs for d8 on linux.

[swarming] Add isolate configs for d8 on linux.

BUG=chromium:535160
LOG=n

Committed: https://crrev.com/7b3e8a4b03461508b20a70c0150d727866a763c9
Cr-Commit-Position: refs/heads/master@{#30943}

[Michael Achenbach, 2015-09-25 10:26:26]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, maruel@chromium.org, tandrii@chromium.org

[Michael Achenbach, 2015-09-25 10:26:27]

PTAL. This is a minimal config - can now be used like:
GYP_GENERATORS=ninja GYP_DEFINES="target_arch=x64 v8_target_arch=x64" gclient
sync
ninja -C out/Debug d8_run
path/to/swarming-client/isolate.py run -s path/to/v8/out/Debug/d8.isolated --
--help

https://codereview.chromium.org/1361953003/diff/1/build/isolate.gypi
File build/isolate.gypi (right):

https://codereview.chromium.org/1361953003/diff/1/build/isolate.gypi#newcode1
build/isolate.gypi:1: # Copyright 2015 the V8 project authors. All rights
reserved.
This is a copy from chromium/src/build with a minimal config for v8. Everything
else removed.

https://codereview.chromium.org/1361953003/diff/1/tools/isolate_driver.py
File tools/isolate_driver.py (right):

https://codereview.chromium.org/1361953003/diff/1/tools/isolate_driver.py#new...
tools/isolate_driver.py:1: #!/usr/bin/env python
Bluntly copied from chromium/src/tools. crbug.com/535922 for tracking the future
of this.

[tandrii(chromium), 2015-09-25 11:52:30]

i don't read Gyp, so i'd rather have someone else check this. Looks reasonable
though.

[jochen (gone - plz use gerrit), 2015-09-25 12:19:09]

https://codereview.chromium.org/1361953003/diff/1/src/base.isolate
File src/base.isolate (right):

https://codereview.chromium.org/1361953003/diff/1/src/base.isolate#newcode10
src/base.isolate:10: '<(PRODUCT_DIR)/snapshot_blob.bin',
what about the icu dll on windows?

[Michael Achenbach, 2015-09-25 12:20:29]

https://codereview.chromium.org/1361953003/diff/1/src/base.isolate
File src/base.isolate (right):

https://codereview.chromium.org/1361953003/diff/1/src/base.isolate#newcode10
src/base.isolate:10: '<(PRODUCT_DIR)/snapshot_blob.bin',
On 2015/09/25 12:19:09, jochen wrote:
> what about the icu dll on windows?

I wanted to start out with a linux-only prototype and add more stuff from
there...

[jochen (gone - plz use gerrit), 2015-09-25 12:20:52]

lgtm

[M-A Ruel, 2015-09-25 12:50:11]

Thanks for looking at this! One note.

https://codereview.chromium.org/1361953003/diff/1/tools/isolate_driver.py
File tools/isolate_driver.py (right):

https://codereview.chromium.org/1361953003/diff/1/tools/isolate_driver.py#new...
tools/isolate_driver.py:1: #!/usr/bin/env python
On 2015/09/25 10:26:26, Michael Achenbach wrote:
> Bluntly copied from chromium/src/tools. crbug.com/535922 for tracking the
future
> of this.

I don't think you need this script as you don't have a ton of runtime binary
dependencies. I'd recommed to just list all executables and dynamic libraries
for now.

This file is also going away with GN.

[Michael Achenbach, 2015-09-25 13:21:35]

Simplified!

https://codereview.chromium.org/1361953003/diff/1/tools/isolate_driver.py
File tools/isolate_driver.py (right):

https://codereview.chromium.org/1361953003/diff/1/tools/isolate_driver.py#new...
tools/isolate_driver.py:1: #!/usr/bin/env python
On 2015/09/25 12:50:11, M-A Ruel wrote:
> On 2015/09/25 10:26:26, Michael Achenbach wrote:
> > Bluntly copied from chromium/src/tools. crbug.com/535922 for tracking the
> future
> > of this.
> 
> I don't think you need this script as you don't have a ton of runtime binary
> dependencies. I'd recommed to just list all executables and dynamic libraries
> for now.
> 
> This file is also going away with GN.

Right, thanks for the hint. I removed the file again and simplified
isolate.gypi. My example still works, cool!

[Michael Achenbach, 2015-09-25 13:22:55]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[M-A Ruel, 2015-09-25 13:22:58]

lgtm

[commit-bot: I haz the power, 2015-09-25 13:23:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361953003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361953003/20001

[Michael Achenbach, 2015-09-25 13:26:32]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2015-09-25 13:26:33]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/1361953003/#ps40001
(title: "Keep test_isolation_mode variable")

[commit-bot: I haz the power, 2015-09-25 13:26:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361953003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361953003/40001

[commit-bot: I haz the power, 2015-09-25 14:37:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-25 14:37:19]

Patchset 3 (id:??) landed as
https://crrev.com/7b3e8a4b03461508b20a70c0150d727866a763c9
Cr-Commit-Position: refs/heads/master@{#30943}

[Mostyn Bramley-Moore, 2015-09-29 13:07:21]

This breaks my gyp build unless I set test_isolation_mode='noop'...

The linked bug has restricted access, can you please add me to it so I can take
a look?  

$ /usr/bin/python src/build/gyp_chromium
Updating projects from gyp files...
Traceback (most recent call last):
  File "src/build/gyp_chromium", line 12, in <module>
    execfile(__file__ + '.py')
  File "src/build/gyp_chromium.py", line 335, in <module>
    sys.exit(main())
  File "src/build/gyp_chromium.py", line 322, in main
    gyp_rc = gyp.main(args)
  File "/home/mostyn/code/upstream/src/tools/gyp/pylib/gyp/__init__.py", line
538, in main
    return gyp_main(args)
  File "/home/mostyn/code/upstream/src/tools/gyp/pylib/gyp/__init__.py", line
514, in gyp_main
    options.duplicate_basename_check)
  File "/home/mostyn/code/upstream/src/tools/gyp/pylib/gyp/__init__.py", line
130, in Load
    params['parallel'], params['root_targets'])
  File "/home/mostyn/code/upstream/src/tools/gyp/pylib/gyp/input.py", line 2789,
in Load
    RemoveLinkDependenciesFromNoneTargets(targets)
  File "/home/mostyn/code/upstream/src/tools/gyp/pylib/gyp/input.py", line 1505,
in RemoveLinkDependenciesFromNoneTargets
    if targets[t].get('variables', {}).get('link_dependency', 0):
KeyError: '/home/mostyn/code/upstream/src/v8/src/d8.gyp:d8#target'

[Michael Achenbach, 2015-09-29 15:14:45]

On 2015/09/29 13:07:21, Mostyn Bramley-Moore wrote:
> This breaks my gyp build unless I set test_isolation_mode='noop'...
> 
> The linked bug has restricted access, can you please add me to it so I can
take
> a look?  
> 
> $ /usr/bin/python src/build/gyp_chromium
> Updating projects from gyp files...
> Traceback (most recent call last):
>   File "src/build/gyp_chromium", line 12, in <module>
>     execfile(__file__ + '.py')
>   File "src/build/gyp_chromium.py", line 335, in <module>
>     sys.exit(main())
>   File "src/build/gyp_chromium.py", line 322, in main
>     gyp_rc = gyp.main(args)
>   File "/home/mostyn/code/upstream/src/tools/gyp/pylib/gyp/__init__.py", line
> 538, in main
>     return gyp_main(args)
>   File "/home/mostyn/code/upstream/src/tools/gyp/pylib/gyp/__init__.py", line
> 514, in gyp_main
>     options.duplicate_basename_check)
>   File "/home/mostyn/code/upstream/src/tools/gyp/pylib/gyp/__init__.py", line
> 130, in Load
>     params['parallel'], params['root_targets'])
>   File "/home/mostyn/code/upstream/src/tools/gyp/pylib/gyp/input.py", line
2789,
> in Load
>     RemoveLinkDependenciesFromNoneTargets(targets)
>   File "/home/mostyn/code/upstream/src/tools/gyp/pylib/gyp/input.py", line
1505,
> in RemoveLinkDependenciesFromNoneTargets
>     if targets[t].get('variables', {}).get('link_dependency', 0):
> KeyError: '/home/mostyn/code/upstream/src/v8/src/d8.gyp:d8#target'

There's not much to see in the bug. Could you please file one against me, with a
detailed repro? Maybe Marc-Antoine knows more. Did this break any official
chromium bot?

[Mostyn Bramley-Moore, 2015-09-29 16:19:46]

> There's not much to see in the bug. Could you please file one against me, with
a
> detailed repro? Maybe Marc-Antoine knows more. Did this break any official
> chromium bot?

Filed https://crbug.com/537247 with a minimal reproduction.