Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1361953002: Surrogate pair line breaking test combined, font added (Closed)

Created:
5 years, 3 months ago by drott
Modified:
5 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Surrogate pair line breaking test combined, font added The test for line breaking was split into two files and didn't have rendering glyphs on all platforms. Fixed that. BUG=535102 R=eae,leviw,kojii Committed: https://crrev.com/679ca9ca5333e72ca2f245f517d4a6f528549fc6 Cr-Commit-Position: refs/heads/master@{#350516}

Patch Set 1 #

Patch Set 2 : rebased to chromium repo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -55 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/midword-break-before-surrogate-pair.html View 1 1 chunk +25 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/text/midword-break-before-surrogate-pair-2.html View 1 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/text/midword-break-before-surrogate-pair-2-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/text/midword-break-before-surrogate-pair-2-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/text/midword-break-before-surrogate-pair-2-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/text/midword-break-before-surrogate-pair-2-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-lion/fast/text/midword-break-before-surrogate-pair-2-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mavericks/fast/text/midword-break-before-surrogate-pair-2-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mountainlion/fast/text/midword-break-before-surrogate-pair-2-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/text/midword-break-before-surrogate-pair-2-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/text/midword-break-before-surrogate-pair-2-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/fast/text/midword-break-before-surrogate-pair-2-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/fast/text/midword-break-before-surrogate-pair-2-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/text/midword-break-before-surrogate-pair-2-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/text/midword-break-before-surrogate-pair-2-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
A + third_party/WebKit/LayoutTests/third_party/NotoSansSymbol/LICENSE.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/third_party/NotoSansSymbol/NotoSansSymbols-Regular-u1d49e,1f1ef.ttf View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/third_party/NotoSansSymbol/README.chromium View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361953002/1
5 years, 3 months ago (2015-09-23 09:20:55 UTC) #2
drott
5 years, 3 months ago (2015-09-23 09:26:12 UTC) #3
eae
LGTM
5 years, 3 months ago (2015-09-23 13:53:50 UTC) #4
drott
rebased to chromium repo
5 years, 3 months ago (2015-09-23 15:47:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361953002/20001
5 years, 3 months ago (2015-09-24 08:48:37 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-24 09:40:58 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 09:42:00 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/679ca9ca5333e72ca2f245f517d4a6f528549fc6
Cr-Commit-Position: refs/heads/master@{#350516}

Powered by Google App Engine
This is Rietveld 408576698