Issue 136193011: MIPS: Fix zlib critical performance regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136193011: MIPS: Fix zlib critical performance regression. (Closed)

Created:
6 years, 10 months ago by dusmil

Modified:
6 years, 10 months ago

Reviewers:
kisg, Paul Lind, palfia, kilvadyb, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Fix zlib critical performance regression. The very low score on zlib benchmark is caused by huge number of deoptimizations inside BinaryOpIC stubs when arguments are boolean. TEST= BUG= Committed: https://code.google.com/p/v8/source/detail?r=19006

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/mips/lithium-codegen-mips.cc	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

LGTM! Thanks for this fix! https://codereview.chromium.org/136193011/diff/1/src/mips/lithium-codegen-mips.cc File src/mips/lithium-codegen-mips.cc (right): https://codereview.chromium.org/136193011/diff/1/src/mips/lithium-codegen-mips.cc#newcode4805 src/mips/lithium-codegen-mips.cc:4805: __ mov(scratch2, input_reg); nit: ...

6 years, 10 months ago (2014-01-31 18:54:39 UTC) #2

Committed as r19006.

Expand Messages | Collapse Messages