Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1361923005: Move net-export resources to //components/net_log (Closed)

Created:
5 years, 3 months ago by droger
Modified:
5 years, 2 months ago
Reviewers:
eroman, Dan Beam, blundell
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move net-export resources to //components/net_log This allows sharing the resources on iOS. TBR=dbeam Committed: https://crrev.com/4fd82ccc9f0200fc7762ff94d00f77b7b7bb333d Cr-Commit-Position: refs/heads/master@{#351067}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -253 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/resources/net_export/net_export.css View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/resources/net_export/net_export.html View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/resources/net_export/net_export.js View 1 chunk +0 lines, -124 lines 0 comments Download
M chrome/browser/ui/webui/net_export_ui.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M components/net_log.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/net_log/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/net_log/net_export_ui_constants.h View 1 chunk +27 lines, -0 lines 0 comments Download
A components/net_log/net_export_ui_constants.cc View 1 chunk +22 lines, -0 lines 0 comments Download
A + components/net_log/resources/net_export.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/net_log/resources/net_export.html View 1 chunk +7 lines, -0 lines 0 comments Download
A + components/net_log/resources/net_export.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M components/resources/components_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
A components/resources/net_log_resources.grdp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
droger
5 years, 3 months ago (2015-09-24 14:03:15 UTC) #4
eroman
lgtm
5 years, 3 months ago (2015-09-24 22:19:39 UTC) #5
droger
+blundell for components/resources
5 years, 3 months ago (2015-09-25 07:20:08 UTC) #6
droger
Adding blundell for real this time.
5 years, 2 months ago (2015-09-28 13:06:10 UTC) #8
blundell
lgtm
5 years, 2 months ago (2015-09-28 13:09:53 UTC) #9
droger
TBR=dbeam for changes in chrome/browser/resources: deleted code and files chrome/browser/ui/webui/net_export_ui.cc: trivial changes
5 years, 2 months ago (2015-09-28 13:17:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361923005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361923005/40001
5 years, 2 months ago (2015-09-28 13:17:30 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 2 months ago (2015-09-28 14:15:49 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4fd82ccc9f0200fc7762ff94d00f77b7b7bb333d Cr-Commit-Position: refs/heads/master@{#351067}
5 years, 2 months ago (2015-09-28 14:16:26 UTC) #15
Dan Beam
5 years, 2 months ago (2015-09-28 16:13:03 UTC) #16
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698