Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1361913003: [arm] Optimize vcmp when lhs operand is #0.0 (Closed)

Created:
5 years, 3 months ago by Pierre Langlois
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Optimize vcmp when lhs operand is #0.0 This patch checks the type of the lhs operand of a floating point comparison for ARM, and commutes the operands if it is #0.0. It allows us to optimize a comparison with zero, as the vcmp instruction accepts #0.0 as rhs operand. Code before for "0.0 < 0.123": ------------------------------ movw ip, #29360 movt ip, #37224 movw r9, #31981 movt r9, #16319 vmov d0, ip, r9 mov ip, #0 vmov d1, ip, ip vcmp.f64 d1, d0 vmrs APSR, FPSCR bcc +12 Code after: ----------- movw ip, #29360 movt ip, #37224 movw r9, #31981 movt r9, #16319 vmov d0, ip, r9 vcmp.f64 d0, #0.0 vmrs APSR, FPSCR bgt +12 BUG= Committed: https://crrev.com/d1472d65dd25b79a65103d6a62af857517aef9cb Cr-Commit-Position: refs/heads/master@{#30911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -61 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 5 chunks +42 lines, -28 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 5 chunks +42 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Pierre Langlois
5 years, 3 months ago (2015-09-24 10:25:43 UTC) #2
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-24 11:10:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361913003/1
5 years, 3 months ago (2015-09-24 11:41:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 12:04:04 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 12:04:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1472d65dd25b79a65103d6a62af857517aef9cb
Cr-Commit-Position: refs/heads/master@{#30911}

Powered by Google App Engine
This is Rietveld 408576698