Issue 13619011: A helper script for testing Native Client builds of V8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13619011: A helper script for testing Native Client builds of V8. (Closed)

Created:
7 years, 8 months ago by Brad Chen

Modified:
7 years, 8 months ago

Reviewers:
danno, Jakob Kummerow

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

A helper script for testing Native Client builds of V8. This is modeled after tools/android-run.py. It is meant to be used as a --command-prefix argument to tools/run-tests.py BUG=2614 Committed: http://code.google.com/p/v8/source/detail?r=14177

Patch Set 1 #

Patch Set 2 : Cleanup and performance fix. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -22 lines)			Patch
	A +	tools/nacl-run.py	View	1	3 chunks	+64 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM (pretty much rubber-stamped). I'll land this.

7 years, 8 months ago (2013-04-09 08:30:15 UTC) #2

Jakob Kummerow

7 years, 8 months ago (2013-04-09 08:31:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r14177 (presubmit successful).

Expand Messages | Collapse Messages