[turbofan] In GraphReducer::Replace, check uses to not misuse the replacement.

[turbofan] In GraphReducer::Replace, check uses to not misuse the replacement.

Committed: https://crrev.com/5b5bde03d806163e3fbc7614464ea6a3d2301cd6
Cr-Commit-Position: refs/heads/master@{#30958}

[Michael Starzinger, 2015-09-25 10:54:17]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2015-09-25 10:54:18]

LGTM. Just one suggestion.

https://codereview.chromium.org/1361893006/diff/1/src/compiler/graph-reducer.cc
File src/compiler/graph-reducer.cc (right):

https://codereview.chromium.org/1361893006/diff/1/src/compiler/graph-reducer....
src/compiler/graph-reducer.cc:165: void VerifyUseReplacement(const Edge& edge,
const Node* replacement) {
suggestion: We could move this verification methods into the verifier.[h|cc]
file (maybe static methods on Verifier or even a separate NodeVerifier with
static methods). Same applies for the NodeProperties::ChangeOp verification. Not
sure it's worth it, up to you.

[Jarin, 2015-09-28 04:51:52]

The CQ bit was checked by jarin@chromium.org

[commit-bot: I haz the power, 2015-09-28 04:51:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361893006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361893006/1

[commit-bot: I haz the power, 2015-09-28 05:37:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-28 05:37:46]

Patchset 1 (id:??) landed as
https://crrev.com/5b5bde03d806163e3fbc7614464ea6a3d2301cd6
Cr-Commit-Position: refs/heads/master@{#30958}