Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1361833002: Screen dynamic invokes to object properties in checker (Closed)

Created:
5 years, 3 months ago by Leaf
Modified:
5 years, 3 months ago
Reviewers:
vsm, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Screen dynamic invokes to object properties in checker. In the old code, when we so o.f (or o.f(..)) and o had type dynamic, we would promote the type of o to Object so that our dynamic invocation code would not emit a dinvoke. This seems a little bit of a hack in the context of the analyzer integration, so this CL eliminates the promotion, and changes the checker to screen out these dynamic invokes. This should eliminate some of the additional dynamic invokes that Vijay is seeing. BUG= R=jmesserly@google.com, vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/a220335ead65df0aed236f590e3c92171c7a572f

Patch Set 1 #

Patch Set 2 : Handle object tearoffs better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M lib/src/checker/checker.dart View 1 4 chunks +22 lines, -3 lines 0 comments Download
M lib/src/checker/resolver.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Leaf
5 years, 3 months ago (2015-09-22 23:14:00 UTC) #2
vsm
Hmm, we might lose tearoffs this way: var f = x.toString; f(); // This should ...
5 years, 3 months ago (2015-09-22 23:22:05 UTC) #3
Jennifer Messerly
LGTM On 2015/09/22 23:22:05, vsm wrote: > Hmm, we might lose tearoffs this way: > ...
5 years, 3 months ago (2015-09-22 23:26:11 UTC) #4
vsm
On 2015/09/22 23:26:11, John Messerly wrote: > LGTM > > On 2015/09/22 23:22:05, vsm wrote: ...
5 years, 3 months ago (2015-09-22 23:27:26 UTC) #5
Leaf
5 years, 3 months ago (2015-09-22 23:29:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a220335ead65df0aed236f590e3c92171c7a572f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698