Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 13618002: add auto-update step to 'fetch' wrappers (Closed)

Created:
7 years, 8 months ago by Dirk Pranke
Modified:
7 years, 8 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M fetch View 1 chunk +4 lines, -0 lines 1 comment Download
M fetch.bat View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dirk Pranke
7 years, 8 months ago (2013-04-04 07:07:36 UTC) #1
iannucci
lgtm
7 years, 8 months ago (2013-04-04 07:39:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/13618002/1
7 years, 8 months ago (2013-04-04 07:44:18 UTC) #3
commit-bot: I haz the power
Failed to apply patch for depot_tools/fetch.bat: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 8 months ago (2013-04-04 07:44:19 UTC) #4
Dirk Pranke
Committed patchset #1 manually as r192233.
7 years, 8 months ago (2013-04-04 07:51:11 UTC) #5
Isaac (away)
7 years, 8 months ago (2013-04-04 18:46:12 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/13618002/diff/1/fetch
File fetch (right):

https://codereview.chromium.org/13618002/diff/1/fetch#newcode8
fetch:8: if [[ "#grep#fetch#cleanup#diff#" != *"#$1#"* ]]; then
This exclusions were to avoid auto-update for certain gclient commands like
'gclient diff' so they were faster.  They don't cause harm here but are probably
not applicable...

Powered by Google App Engine
This is Rietveld 408576698