Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 1361763006: [Presentation API, Android] Plumbing SendBinaryMessage() from C++ MediaRouterAndroid to java side. (Closed)

Created:
5 years, 3 months ago by sarath.singapati
Modified:
5 years, 2 months ago
Reviewers:
whywhat
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, media-router+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Presentation API, Android] Plumbing SendBinaryMessage() from C++ MediaRouterAndroid to java side. This CL adds plumbing for SendBinaryMessage() from C++ Media Router implementation on Android to ChromeMediaRouter java implementation and upto Cast application session. BUG=524128 Committed: https://crrev.com/6f76d28fef459a3baa6ec7ab0e81e53733c9bc58 Cr-Commit-Position: refs/heads/master@{#353121}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Rebase #

Messages

Total messages: 18 (7 generated)
sarath.singapati
PTAL. Hi Anton, I tried to follow the sendString() implementation. Tested this patch upto ChromeMediaRouter.java ...
5 years, 3 months ago (2015-09-24 19:50:47 UTC) #2
whywhat
lgtm % comments https://codereview.chromium.org/1361763006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java File chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java (right): https://codereview.chromium.org/1361763006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java#newcode155 chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java:155: RouteController route = mRoutes.get(routeId); I don't ...
5 years, 2 months ago (2015-09-29 07:40:31 UTC) #3
sarath.singapati
https://codereview.chromium.org/1361763006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java File chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java (right): https://codereview.chromium.org/1361763006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java#newcode155 chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java:155: RouteController route = mRoutes.get(routeId); On 2015/09/29 07:40:31, whywhat wrote: ...
5 years, 2 months ago (2015-09-30 18:10:49 UTC) #4
sarath.singapati
PTAL.
5 years, 2 months ago (2015-10-05 21:59:48 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361763006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361763006/20001
5 years, 2 months ago (2015-10-06 20:47:56 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/128504) android_chromium_gn_compile_dbg on ...
5 years, 2 months ago (2015-10-06 20:55:34 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361763006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361763006/40001
5 years, 2 months ago (2015-10-08 16:25:36 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-08 18:23:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361763006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361763006/40001
5 years, 2 months ago (2015-10-08 19:21:06 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-08 19:27:45 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 19:29:13 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6f76d28fef459a3baa6ec7ab0e81e53733c9bc58
Cr-Commit-Position: refs/heads/master@{#353121}

Powered by Google App Engine
This is Rietveld 408576698