[Presentation API, Android] Plumbing SendBinaryMessage() from C++ MediaRouterAndroid to java side.

[Presentation API, Android] Plumbing SendBinaryMessage() from C++ MediaRouterAndroid to java side.

This CL adds plumbing for SendBinaryMessage() from C++ Media Router implementation on Android
to ChromeMediaRouter java implementation and upto Cast application session.

BUG=524128
Committed: https://crrev.com/6f76d28fef459a3baa6ec7ab0e81e53733c9bc58
Cr-Commit-Position: refs/heads/master@{#353121}

[sarath.singapati, 2015-09-24 19:50:46]

s.singapati@gmail.com changed reviewers:
+ avayvod@chromium.org

[sarath.singapati, 2015-09-24 19:50:47]

PTAL.

Hi Anton, I tried to follow the sendString() implementation. Tested this patch
upto ChromeMediaRouter.java using logs. I will see if more testing can be done.
Thanks.

[whywhat, 2015-09-29 07:40:31]

lgtm % comments

https://codereview.chromium.org/1361763006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java
(right):

https://codereview.chromium.org/1361763006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java:155:
RouteController route = mRoutes.get(routeId);
I don't think Cast supports sending binary messages to the apps in a generic
way. If the Cast web page wants to send a blob, it will stringify it somehow and
send as an app_message within it's own message namespace, using the string
version of the PresentationSession/Connection interface.

I think here you should always call onMessageSentResult(false,
nativeCallbackId).

[sarath.singapati, 2015-09-30 18:10:49]

https://codereview.chromium.org/1361763006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java
(right):

https://codereview.chromium.org/1361763006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java:155:
RouteController route = mRoutes.get(routeId);
On 2015/09/29 07:40:31, whywhat wrote:
> I don't think Cast supports sending binary messages to the apps in a generic
> way. If the Cast web page wants to send a blob, it will stringify it somehow
and
> send as an app_message within it's own message namespace, using the string
> version of the PresentationSession/Connection interface.
> 
> I think here you should always call onMessageSentResult(false,
> nativeCallbackId).

Or, shall we call onMessageSentResult(false, callbackId) from SessionWrapper 
instead of here? Would there be any problem?

And later check the possibility to stringify it somehow & send as String.

[sarath.singapati, 2015-10-05 21:59:48]

PTAL.

[sarath.singapati, 2015-10-06 20:43:48]

The CQ bit was checked by s.singapati@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-06 20:47:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361763006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361763006/20001

[commit-bot: I haz the power, 2015-10-06 20:55:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-06 20:55:34]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[sarath.singapati, 2015-10-08 16:24:38]

The CQ bit was checked by s.singapati@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-08 16:25:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361763006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361763006/40001

[commit-bot: I haz the power, 2015-10-08 18:23:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-08 18:23:13]

Dry run: This issue passed the CQ dry run.

[sarath.singapati, 2015-10-08 19:20:21]

The CQ bit was checked by s.singapati@gmail.com

[sarath.singapati, 2015-10-08 19:20:21]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/1361763006/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2015-10-08 19:21:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361763006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361763006/40001

[commit-bot: I haz the power, 2015-10-08 19:27:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-08 19:29:13]

Patchset 3 (id:??) landed as
https://crrev.com/6f76d28fef459a3baa6ec7ab0e81e53733c9bc58
Cr-Commit-Position: refs/heads/master@{#353121}