src/base/logging.h - Issue 1361763004: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/base/logging.h

Issue 1361763004: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: gcc 4.8 doesn't understand #pragma ignored Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/base/logging.h

diff --git a/src/base/logging.h b/src/base/logging.h

index 511ebf1e9c3e5af344eaaf809fb0726003768fe5..a3f498748e64e3248c2ba9a83eacdfb7a246e8e1 100644

--- a/src/base/logging.h

+++ b/src/base/logging.h

@@ -11,7 +11,8 @@

#include "src/base/build_config.h"

-extern "C" void V8_Fatal(const char* file, int line, const char* format, ...);

+extern "C" V8_NORETURN void V8_Fatal(const char* file, int line,

+ const char* format, ...);

// The FATAL, UNREACHABLE and UNIMPLEMENTED macros are useful during

« no previous file with comments | « include/v8config.h ('k') | src/base/platform/platform.h » ('j') | no next file with comments »