Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1361703005: Use --incremental when dex'ing (when possible). (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@javac-incremental
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds --incremental to dex.py, and a GN flag for enabling it. Timings for the dex.py step of chrome_java with one file changed: Before: real 0m8.068s user 0m46.996s sys 0m3.553s After: real 0m1.854s user 0m3.074s sys 0m0.237s BUG=533442 Committed: https://crrev.com/e000f9b73cadf25277b401b5a6b27f215aaba1ad Cr-Commit-Position: refs/heads/master@{#350750}

Patch Set 1 #

Patch Set 2 : dex merging #

Patch Set 3 : add flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -13 lines) Patch
M build/android/gyp/dex.py View 1 2 3 chunks +56 lines, -13 lines 0 comments Download
M build/config/android/config.gni View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
Yaron
lgtm
5 years, 3 months ago (2015-09-24 19:29:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361703005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361703005/40001
5 years, 3 months ago (2015-09-25 01:04:57 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-25 02:31:29 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-25 02:32:42 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e000f9b73cadf25277b401b5a6b27f215aaba1ad
Cr-Commit-Position: refs/heads/master@{#350750}

Powered by Google App Engine
This is Rietveld 408576698