Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 1361663003: Revert of Cache gpu suitability in DisplayItemList, remove SetUnsuitable...ForTesting (Closed)

Created:
5 years, 3 months ago by pdr.
Modified:
5 years, 3 months ago
Reviewers:
danakj, hendrikw
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Cache gpu suitability in DisplayItemList, remove SetUnsuitable...ForTesting (patchset #7 id:120001 of https://codereview.chromium.org/1349913002/ ) Reason for revert: Crashes :'( http://crbug.com/534810 Original issue's description: > Cache gpu suitability in DisplayItemList, remove SetUnsuitable...ForTesting > > This patch moves the gpu suitability "cache" into display_item_list > so that calls to DisplayItemList::IsSuitableForGpuRasterization are > fast. With the cache moved we no longer need to track suitability in > the recording source and can remove SetUnsuitableForGpuRasterizationForTesting. > > BUG=524314 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/5d8f98c33491997b3ffa1c8494fe6014c4b8e4c9 > Cr-Commit-Position: refs/heads/master@{#349999} TBR=danakj@chromium.org,hendrikw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=524314 Committed: https://crrev.com/f57db89518aec3379e1a34e202e14d72657ff285 Cr-Commit-Position: refs/heads/master@{#350190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -102 lines) Patch
M cc/layers/picture_layer_unittest.cc View 2 chunks +4 lines, -19 lines 0 comments Download
M cc/playback/display_item_list.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/playback/display_item_list.cc View 4 chunks +17 lines, -16 lines 0 comments Download
M cc/playback/display_list_recording_source.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/playback/display_list_recording_source.cc View 5 chunks +11 lines, -7 lines 0 comments Download
M cc/playback/picture_pile.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/playback/picture_pile.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/playback/recording_source.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/test/fake_display_list_recording_source.h View 1 chunk +1 line, -3 lines 0 comments Download
M cc/test/fake_display_list_recording_source.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 9 chunks +39 lines, -55 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pdr.
Created Revert of Cache gpu suitability in DisplayItemList, remove SetUnsuitable...ForTesting
5 years, 3 months ago (2015-09-22 17:59:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361663003/1
5 years, 3 months ago (2015-09-22 18:00:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361663003/1
5 years, 3 months ago (2015-09-22 18:03:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-22 18:08:48 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 18:44:07 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f57db89518aec3379e1a34e202e14d72657ff285
Cr-Commit-Position: refs/heads/master@{#350190}

Powered by Google App Engine
This is Rietveld 408576698