Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Issue 1361633004: GN: Do not use forward_dependent_configs_from variable. (Closed)

Created:
5 years, 3 months ago by tfarina
Modified:
5 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, tim+watch_chromium.org, qsr+mojo_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, maxbogue+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Do not use forward_dependent_configs_from variable. It is deprecated and public_deps should be used instead, which will have the same effect. BUG=None TEST=gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1' R=brettw@chromium.org Committed: https://crrev.com/3a025353ed7d5639017b9a7f20da47e046f33372 Cr-Commit-Position: refs/heads/master@{#350250}

Patch Set 1 #

Total comments: 2

Patch Set 2 : sync fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M build/config/ios/rules.gni View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/mojo_application.gni View 2 chunks +0 lines, -6 lines 0 comments Download
M sync/BUILD.gn View 1 1 chunk +3 lines, -2 lines 0 comments Download
M testing/test.gni View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/mojo_application.gni View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tfarina
5 years, 3 months ago (2015-09-22 17:11:11 UTC) #1
brettw
lgtm https://codereview.chromium.org/1361633004/diff/1/sync/BUILD.gn File sync/BUILD.gn (right): https://codereview.chromium.org/1361633004/diff/1/sync/BUILD.gn#newcode765 sync/BUILD.gn:765: "//third_party/protobuf:protobuf_lite", We should remove this line now.
5 years, 3 months ago (2015-09-22 18:20:20 UTC) #2
tfarina
https://codereview.chromium.org/1361633004/diff/1/sync/BUILD.gn File sync/BUILD.gn (right): https://codereview.chromium.org/1361633004/diff/1/sync/BUILD.gn#newcode765 sync/BUILD.gn:765: "//third_party/protobuf:protobuf_lite", On 2015/09/22 18:20:20, brettw wrote: > We should ...
5 years, 3 months ago (2015-09-22 19:32:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361633004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361633004/20001
5 years, 3 months ago (2015-09-22 19:33:53 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-22 21:56:23 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 22:09:45 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a025353ed7d5639017b9a7f20da47e046f33372
Cr-Commit-Position: refs/heads/master@{#350250}

Powered by Google App Engine
This is Rietveld 408576698