Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1361633003: Work around <webview> focus bugs by enforcing focus event invariants. (Closed)

Created:
5 years, 3 months ago by David Tseng
Modified:
5 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, arv+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Work around <webview> focus bugs by enforcing focus eventinvariants. Workarounds are necessary due to webview firing events out of order. Example, a focus event gets fired on a descendant then the root of the webview when entering the webview via tab key. Similarly, tabbing out of the webview causes a focus event on the root as well. This cl depends on a Blink change to fire blur events to accurately report focus state. Invariants: - the root of the focus target should have focused state set to true (except for nodes with the root as desktop, which is implicitly always focused). - embedded objects should never be focused (even though webview fires focus events on them) - a sequence of focus events like focus event: root.firstChild focus event: root should result in ChromeVox focus remaining on root.firstChild TEST=Tab/shift tab behaves correctly on GAIA sign in page. BUG=534619, 525643 Committed: https://crrev.com/d336af2c96432f9c8d4b55faa3646c78c14607c7 Cr-Commit-Position: refs/heads/master@{#352127}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 2 chunks +18 lines, -10 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
David Tseng
5 years, 3 months ago (2015-09-22 15:55:48 UTC) #2
Fady Samuel
On 2015/09/22 15:55:48, David Tseng wrote: >  Please file a bug and assign to ...
5 years, 3 months ago (2015-09-22 15:57:19 UTC) #3
David Tseng
On 2015/09/22 15:57:19, Fady Samuel wrote: > On 2015/09/22 15:55:48, David Tseng wrote: > > ...
5 years, 2 months ago (2015-09-29 22:04:19 UTC) #4
David Tseng
On 2015/09/29 22:04:19, David Tseng wrote: > On 2015/09/22 15:57:19, Fady Samuel wrote: > > ...
5 years, 2 months ago (2015-09-30 16:36:55 UTC) #5
dmazzoni
lgtm as a temporary workaround. I hope to have a cleaner solution soon, waiting on ...
5 years, 2 months ago (2015-09-30 16:39:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361633003/1
5 years, 2 months ago (2015-09-30 16:40:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/69392)
5 years, 2 months ago (2015-09-30 17:25:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361633003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361633003/20001
5 years, 2 months ago (2015-10-02 20:59:33 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-02 21:06:55 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 21:07:45 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d336af2c96432f9c8d4b55faa3646c78c14607c7
Cr-Commit-Position: refs/heads/master@{#352127}

Powered by Google App Engine
This is Rietveld 408576698