Issue 136163002: Whitelist environment variables used from Official chrome builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136163002: Whitelist environment variables used from Official chrome builds (Closed)

Created:
6 years, 11 months ago by scottmg

Modified:
6 years, 11 months ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk

Visibility:
Public.

ninja win: Whitelist environment variables used from Official Chrome This is ugly, but needed to be able to pass environment variables through in the official compile process. They're set here: https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/slave/compile.py&l=416 R=thakis@chromium.org BUG=333738

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	pylib/gyp/msvs_emulation.py	View		2 chunks	+6 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Nico

This was abandoned in favor of https://code.google.com/p/gyp/source/detail?r=1836 , right? (Let me know if I should ...

6 years, 11 months ago (2014-01-14 02:08:27 UTC) #2

scottmg

6 years, 11 months ago (2014-01-14 03:26:47 UTC) #3

Sorry, yes it was. I don't think this is much cleaner than the other, so
closing.