Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1361613002: Move all core files in //components/sessions into core/ subdir (Closed)

Created:
5 years, 3 months ago by blundell
Modified:
5 years, 3 months ago
Reviewers:
droger, Finnur, sky
CC:
chromium-reviews, skanuj+watch_chromium.org, zea+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, dcheng, tim+watch_chromium.org, extensions-reviews_chromium.org, melevin+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, darin-cc_chromium.org, donnd+watch_chromium.org, David Black, jennb, jianli, jfweitz+watch_chromium.org, chromium-apps-reviews_chromium.org, Jered, sdefresne+watch_chromium.org, maxbogue+watch_chromium.org, Dmitry Titov, plaree+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move all core files in //components/sessions into core/ subdir //components/sessions has many core files living in the top-level directory of the component. This CL moves all the core files to live in //components/sessions/core to match the conventional structure of a layered component. TBR=finnur,droger BUG=371476 NOPRESUBMIT=true Committed: https://crrev.com/47c6d8a6957fae50ec6550325ff816da202f04c5 Cr-Commit-Position: refs/heads/master@{#350529}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -4359 lines) Patch
M chrome/browser/android/tab_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/tab_state.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/browser_extension_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/window_controller_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/jumplist_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/search.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/persistent_tab_restore_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_restore.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_restore_browsertest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_service_test_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_service_test_helper.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sessions/session_service_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/session_sync_test_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/synced_session_tracker.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/synced_session_tracker_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/synced_session_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/synced_session_util_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/synced_tab_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/synced_window_delegate_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sessions/sessions_sync_manager.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/sessions_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/tab_model/tab_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/tab_model/tab_model_list.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_tabrestore.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/tab_applescript.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/settings_window_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/browser_synced_window_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/browser_synced_window_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/browser_synced_window_delegates_getter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/components_tests.gyp View 1 7 chunks +7 lines, -7 lines 0 comments Download
M components/omnibox/browser/omnibox_log.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions.gypi View 3 chunks +21 lines, -21 lines 0 comments Download
M components/sessions/BUILD.gn View 5 chunks +24 lines, -24 lines 0 comments Download
D components/sessions/base_session_service.h View 1 chunk +0 lines, -137 lines 0 comments Download
D components/sessions/base_session_service.cc View 1 chunk +0 lines, -185 lines 0 comments Download
D components/sessions/base_session_service_commands.h View 1 chunk +0 lines, -79 lines 0 comments Download
D components/sessions/base_session_service_commands.cc View 1 chunk +0 lines, -150 lines 0 comments Download
D components/sessions/base_session_service_delegate.h View 1 chunk +0 lines, -42 lines 0 comments Download
D components/sessions/base_session_service_test_helper.h View 1 chunk +0 lines, -42 lines 0 comments Download
D components/sessions/base_session_service_test_helper.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M components/sessions/content/content_live_tab.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/content/content_platform_specific_tab_data.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/content/content_serialized_navigation_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/content/content_serialized_navigation_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/content/content_serialized_navigation_builder_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sessions/content/content_serialized_navigation_driver.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/content/content_serialized_navigation_driver.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/content/content_serialized_navigation_driver_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/sessions/core/base_session_service.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + components/sessions/core/base_session_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/sessions/core/base_session_service_commands.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/sessions/core/base_session_service_commands.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/sessions/core/base_session_service_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sessions/core/base_session_service_test_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sessions/core/base_session_service_test_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sessions/core/in_memory_tab_restore_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/core/live_tab.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sessions/core/persistent_tab_restore_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/core/persistent_tab_restore_service.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/sessions/core/serialized_navigation_driver.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/sessions/core/serialized_navigation_entry.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + components/sessions/core/serialized_navigation_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sessions/core/serialized_navigation_entry_test_helper.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/sessions/core/serialized_navigation_entry_test_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/sessions/core/serialized_navigation_entry_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/sessions/core/session_backend.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + components/sessions/core/session_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sessions/core/session_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sessions/core/session_command.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/sessions/core/session_command.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/core/session_constants.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/sessions/core/session_id.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/sessions/core/session_id.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sessions/core/session_service_commands.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + components/sessions/core/session_service_commands.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + components/sessions/core/session_types.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + components/sessions/core/session_types.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/sessions/core/session_types_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/sessions/core/sessions_export.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/sessions/core/tab_restore_service.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/sessions/core/tab_restore_service_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sessions/core/tab_restore_service_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sessions/core/tab_restore_service_helper.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sessions/core/tab_restore_service_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sessions/core/tab_restore_service_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/ios/ios_serialized_navigation_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/ios/ios_serialized_navigation_builder_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sessions/ios/ios_serialized_navigation_driver.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/ios/ios_serialized_navigation_driver_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D components/sessions/serialized_navigation_entry.h View 1 chunk +0 lines, -146 lines 0 comments Download
D components/sessions/serialized_navigation_entry.cc View 1 chunk +0 lines, -473 lines 0 comments Download
D components/sessions/serialized_navigation_entry_test_helper.h View 1 chunk +0 lines, -97 lines 0 comments Download
D components/sessions/serialized_navigation_entry_test_helper.cc View 1 chunk +0 lines, -159 lines 0 comments Download
D components/sessions/serialized_navigation_entry_unittest.cc View 1 chunk +0 lines, -227 lines 0 comments Download
D components/sessions/session_backend.h View 1 chunk +0 lines, -145 lines 0 comments Download
D components/sessions/session_backend.cc View 1 chunk +0 lines, -407 lines 0 comments Download
D components/sessions/session_backend_unittest.cc View 1 chunk +0 lines, -209 lines 0 comments Download
D components/sessions/session_command.h View 1 chunk +0 lines, -75 lines 0 comments Download
D components/sessions/session_command.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D components/sessions/session_id.h View 1 chunk +0 lines, -27 lines 0 comments Download
D components/sessions/session_id.cc View 1 chunk +0 lines, -11 lines 0 comments Download
D components/sessions/session_service_commands.h View 1 chunk +0 lines, -108 lines 0 comments Download
D components/sessions/session_service_commands.cc View 1 chunk +0 lines, -873 lines 0 comments Download
D components/sessions/session_types.h View 1 chunk +0 lines, -178 lines 0 comments Download
D components/sessions/session_types.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D components/sessions/session_types_unittest.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D components/sessions/sessions_export.h View 1 chunk +0 lines, -34 lines 0 comments Download
M components/sync_driver/favicon_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/glue/synced_session.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync_driver/glue/synced_window_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/open_tabs_ui_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync_driver/revisit/current_tab_matcher.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/revisit/current_tab_matcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/revisit/current_tab_matcher_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync_driver/revisit/offset_tab_matcher.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/revisit/offset_tab_matcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/revisit/offset_tab_matcher_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync_driver/revisit/sessions_page_revisit_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/revisit/sessions_page_revisit_observer_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync_driver/sessions/synced_window_delegates_getter.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/tab_node_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/app_window/app_window.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sessions/ios_chrome_session_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (8 generated)
blundell
Hi Scott, Not TBR'ing this just on the off chance that there was some reason ...
5 years, 3 months ago (2015-09-22 13:27:24 UTC) #2
sky
I don't think there was a good reason not to combine as you have here. ...
5 years, 3 months ago (2015-09-22 16:39:07 UTC) #3
blundell
TBR=finnur for //extensions TBR=droger for //ios
5 years, 3 months ago (2015-09-24 07:30:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361613002/1
5 years, 3 months ago (2015-09-24 07:31:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/58388) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 3 months ago (2015-09-24 07:35:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361613002/20001
5 years, 3 months ago (2015-09-24 08:44:20 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/103290)
5 years, 3 months ago (2015-09-24 08:55:29 UTC) #14
blundell
Adding NOPRESUBMIT=true to work around a complaint about using ScopedAllowIO() which is in pre-existing code.
5 years, 3 months ago (2015-09-24 10:05:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361613002/20001
5 years, 3 months ago (2015-09-24 10:06:46 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-24 11:06:58 UTC) #18
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/47c6d8a6957fae50ec6550325ff816da202f04c5 Cr-Commit-Position: refs/heads/master@{#350529}
5 years, 3 months ago (2015-09-24 11:07:50 UTC) #19
Finnur
5 years, 3 months ago (2015-09-24 13:20:06 UTC) #20
Message was sent while issue was closed.
Extensions LGTM

Powered by Google App Engine
This is Rietveld 408576698