Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 136153003: DevTools: [Styles] Add all known unicode-bidi values to CSSMetadata (Closed)

Created:
6 years, 11 months ago by apavlov
Modified:
6 years, 11 months ago
Reviewers:
eustas, vsevik, aandrey, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: [Styles] Add all known unicode-bidi values to CSSMetadata Add 3 more values, according to http://dev.w3.org/csswg/css-writing-modes/#propdef-unicode-bidi R=aandrey, eustas, vsevik BUG=334096 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/CSSMetadata.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
apavlov
6 years, 11 months ago (2014-01-14 13:34:01 UTC) #1
pfeldman
lgtm
6 years, 11 months ago (2014-01-14 13:48:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/136153003/1
6 years, 11 months ago (2014-01-14 13:48:58 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 11 months ago (2014-01-14 15:49:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/136153003/1
6 years, 11 months ago (2014-01-14 15:54:10 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 15:59:39 UTC) #6
Message was sent while issue was closed.
Change committed as 165074

Powered by Google App Engine
This is Rietveld 408576698