tools/perf/core/project_config.py - Issue 1361523003: Add crash_service to Telemetry's isolates.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/core/project_config.py

Issue 1361523003: Add crash_service to Telemetry's isolates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fck

Patch Set: Create isolate for binary_manager dependencies. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« tools/perf/core/binary_dependencies.json ('K') | « tools/perf/core/binary_dependencies.json ('k') | tools/telemetry/catapult_base/dependency_manager/dependency_manager.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright (c) 2015 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import os	5 import os

6 import sys	6 import sys

7	7

8 sys.path.append(os.path.join(	8 sys.path.append(os.path.join(

9 os.path.dirname(__file__), os.pardir, os.pardir, 'telemetry'))	9 os.path.dirname(__file__), os.pardir, os.pardir, 'telemetry'))

10 from telemetry import benchmark_runner	10 from telemetry import benchmark_runner

11	11

12 top_level_dir = os.path.dirname(os.path.realpath(	12 top_level_dir = os.path.dirname(os.path.realpath(

13 os.path.join(__file__, os.pardir)))	13 os.path.join(__file__, os.pardir)))

14	14

	15 binary_dependencies_file = os.path.join(os.path.dirname(__file__),
	M-A Ruel 2015/09/22 21:02:35 os.path.abspath() so it's os.chdir() safe. os.path.abspath() so it's os.chdir() safe. aiolos (Not reviewing) 2015/09/22 21:39:47 Done. Thanks. Show quoted text On 2015/09/22 21:02:35, M-A Ruel wrote: > os.path.abspath() > > so it's os.chdir() safe. Done. Thanks.
	16 'binary_dependencies.json')

	17

15 config = benchmark_runner.ProjectConfig(	18 config = benchmark_runner.ProjectConfig(

16 top_level_dir=top_level_dir,	19 top_level_dir=top_level_dir,

17 benchmark_dirs=[os.path.join(top_level_dir, 'benchmarks')])	20 benchmark_dirs=[os.path.join(top_level_dir, 'benchmarks')],

	21 client_config=binary_dependencies_file)

18	22

19 config.telemetry_dir = os.path.realpath(os.path.join(	23 config.telemetry_dir = os.path.realpath(os.path.join(

20 top_level_dir, os.pardir, 'telemetry'))	24 top_level_dir, os.pardir, 'telemetry'))

21	25

OLD	NEW