tools/perf/core/binary_dependencies.json - Issue 1361523003: Add crash_service to Telemetry's isolates.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/core/binary_dependencies.json

Issue 1361523003: Add crash_service to Telemetry's isolates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fck

Patch Set: Create isolate for binary_manager dependencies. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 {

	2 "config_type": "BaseConfig",

	3 "dependencies": {

	4 "crash_service": {

	5 "file_info": {

	6 "win_AMD64": {

	7 "local_paths": [

	8 "../../../out/Debug/crash_service.exe",
	M-A Ruel 2015/09/22 21:02:35 This is not correct on Win x64 though This is not correct on Win x64 though Ken Russell (switch to Gerrit) 2015/09/22 21:16:58 I think Telemetry's notion of the platform is diff Show quoted text On 2015/09/22 21:02:35, M-A Ruel wrote: > This is not correct on Win x64 though I think Telemetry's notion of the platform is different than Chromium's build. We could add more local_paths if it turns out that Telemetry's "win_AMD64" platform has to support both 32- and 64-bit builds. aiolos (Not reviewing) 2015/09/22 21:39:47 Telemetry's notion is different, which is why I ad Show quoted text On 2015/09/22 21:16:58, Ken Russell wrote: > On 2015/09/22 21:02:35, M-A Ruel wrote: > > This is not correct on Win x64 though > > I think Telemetry's notion of the platform is different than Chromium's build. > We could add more local_paths if it turns out that Telemetry's "win_AMD64" > platform has to support both 32- and 64-bit builds. Telemetry's notion is different, which is why I added some logging in the dependency_manager to help determine when we're looking at the local files for any platforms that we've missed. win_AMD64 is the only platform we have supported in the current system (support_binaries). Instead of guessing what's broken because we don't have support for it, I figured I'd add support where we know we need it, and do a second pass for any bots that aren't fixed.
	9 "../../../out/Release/crash_service.exe"

	10 ]

	11 }

	12 }

	13 }

	14 }

	15 }

OLD	NEW

« no previous file with comments | « content/telemetry_gpu_unittests.isolate ('k') | tools/perf/core/project_config.py » ('j') | tools/perf/core/project_config.py » ('J')