Add crash_service to Telemetry's isolates.

chrome/test/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//chrome/chrome_tests.gni")
@@ skipping 201 matching lines @@
   }
 
   if (enable_extensions) {
     deps += [
       "//chrome/common/extensions/api",
       "//extensions:test_support",
     ]
   }
 }
 
+source_set("telemtry_binary_deps") {

[Dirk Pranke, 2015/09/25 20:16:20]

if there's no sources, it shouldn't be a source_set(). 

Does group() work (I think it should)?

[aiolos (Not reviewing), 2015/09/25 20:40:06]

Yep. I went with that since the only other target I saw that only specified
data_deps was a source_set.

Done.

+  # Telemetry's chrome built dependencies.

[Dirk Pranke, 2015/09/25 20:16:20]

I don't understand this comment? 

[aiolos (Not reviewing), 2015/09/25 20:40:06]

Meant to convey that this target is specifically for specifying the location of
the binary dependencies that are built with chrome/chromium, and not part of
telemetry itself. Removed to avoid confusion.

+  data_deps = []
+
+  if (is_win) {
+    data_deps += [ "//content/shell:crash_service" ]
+  }
+
+  data = [
+    "//tools/perf/core/binary_dependencies.json",
+  ]
+}
+
 if (!is_android) {
   import("//third_party/protobuf/proto_library.gni")
 
   # GYP version: chrome/chrome_tests_unit.gypi:ipc_protobuf_message_test_proto
   proto_library("test_proto") {
     sources = [
       "../common/safe_browsing/ipc_protobuf_message_test.proto",
     ]
   }
 
@@ skipping 361 matching lines @@
   # TODO(GYP): Delete this after we've converted everything to GN.
   # The _run targets exist only for compatibility w/ GYP.
   group("telemetry_gpu_test_run") {
     testonly = true
     deps = [
       ":telemetry_gpu_test",
     ]
   }
 
   group("telemetry_gpu_test") {
+    deps = [
+      "//content/test:telemetry_test_support",
+      ":telemtry_binary_deps",

[Dirk Pranke, 2015/09/25 20:16:20]

typo: ":telemetry" ?

[aiolos (Not reviewing), 2015/09/25 20:40:07]

Done.

+    ]
     data_deps = [
       "//chrome",
       "//tools/telemetry:bitmaptools",
     ]
 
     data = [
       "//content/test/gpu/",
       "//content/test/data/gpu/",
 
       # For GpuProcess.video
       "//content/test/data/media/bear.ogv",
       "//third_party/catapult/",
 
       # For webgl_conformance
       "//third_party/webgl/",
       "//content/test/gpu/run_gpu_test.py",
-
-      # Generic telemetry deps
-      # TODO(GYP): These should probably be specified somewhere else
-      # and pulled in via a deps entry.
-      "//build/android/devil/",
-      "//build/android/pylib/",
-      "//build/util/",
-      "//third_party/WebKit/PerformanceTests/resources/jquery.tablesorter.min.js",
-      "//third_party/WebKit/PerformanceTests/resources/statistics.js",
-      "//third_party/flot/jquery.flot.min.js",
-      "//third_party/webpagereplay/",
-      "//tools/telemetry/",
     ]
 
     if (is_win && (symbol_level == 1 || symbol_level == 2)) {
       # TODO(GYP): These should be provided automatically through data_deps.
       data += [ "$root_out_dir/chrome.exe.pdb" ]
       if (is_component_build) {
         data += [
           "$root_out_dir/base.dll.pdb",
           "$root_out_dir/blink_platform.dll.pdb",
           "$root_out_dir/blink_web.dll.pdb",
@@ skipping 1376 matching lines @@
     "//third_party/mojo/src/mojo/edk/system",
   ]
 
   if (!is_android && use_ash) {
     sources += rebase_path(
             chrome_tests_unit_gypi_values.chrome_test_support_unit_ash_sources,
             ".",
             "//chrome")
   }
 }