Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1361513002: Improve ContentVerifierTest.Fail* tests (Closed)

Created:
5 years, 3 months ago by asargent_no_longer_on_chrome
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve ContentVerifierTest.Fail* tests A bug report pointed out the FailOnDone test isn't succeeding for the right reason, so this makes it more explicit. Also fix a few lint errors in affected files. BUG=534500 Committed: https://crrev.com/b8af815ce364774287bb71349cc6d4edca860a75 Cr-Commit-Position: refs/heads/master@{#357383}

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -17 lines) Patch
M chrome/browser/extensions/content_verifier_browsertest.cc View 1 6 chunks +26 lines, -9 lines 0 comments Download
M extensions/browser/content_verify_job.cc View 1 5 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
asargent_no_longer_on_chrome
5 years, 1 month ago (2015-10-30 17:39:48 UTC) #4
Ken Rockot(use gerrit already)
lgtm
5 years, 1 month ago (2015-10-31 17:46:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361513002/20001
5 years, 1 month ago (2015-11-02 17:10:44 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-02 17:56:43 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 17:57:33 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b8af815ce364774287bb71349cc6d4edca860a75
Cr-Commit-Position: refs/heads/master@{#357383}

Powered by Google App Engine
This is Rietveld 408576698