Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1361503003: libchrome: add support for synchronous PropertySet::Set to dbus (Closed)

Created:
5 years, 3 months ago by nywang
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

libchrome: add support for synchronous PropertySet::Set to dbus The existing PropertySet::Set function is asynchronous. This CL adds the synchronous version of PropertySet::Set. It is defined as PropertySet::SetAndBlock. BUG=https://b.corp.google.com/u/0/issues/24131409 TEST=manually tested Committed: https://crrev.com/8dbb26ec72f34075d951cbfd576fe2165e2f2e69 Cr-Commit-Position: refs/heads/master@{#350268}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M dbus/property.h View 2 chunks +8 lines, -0 lines 0 comments Download
M dbus/property.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
nywang
5 years, 3 months ago (2015-09-22 22:10:14 UTC) #3
keybuk
lgtm
5 years, 3 months ago (2015-09-22 22:41:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361503003/1
5 years, 3 months ago (2015-09-22 22:42:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/35497)
5 years, 3 months ago (2015-09-22 23:25:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361503003/1
5 years, 3 months ago (2015-09-22 23:36:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-23 00:06:47 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 00:08:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8dbb26ec72f34075d951cbfd576fe2165e2f2e69
Cr-Commit-Position: refs/heads/master@{#350268}

Powered by Google App Engine
This is Rietveld 408576698