third_party/WebKit/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp - Issue 1361413004: Fix directly composited image path for CSS image-orientation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp

Issue 1361413004: Fix directly composited image path for CSS image-orientation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test for 0deg Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/image-orientation/image-orientation-from-image-composited-dynamic.html ('k') | third_party/WebKit/Source/core/page/DragController.cpp » ('j') | third_party/WebKit/Source/platform/DragImage.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp

index 7b5bbd911e2a2e0a8a67e4e2d769942097a2ba2f..f628c72456604f557d7caf2c949cab7d6fdecf08 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp

@@ -1871,10 +1871,7 @@ bool CompositedDeprecatedPaintLayerMapping::isDirectlyCompositedImage() const

if (!image->isBitmapImage())

return false;

- // FIXME: We should be able to handle bitmap images using direct compositing

- // no matter what image-orientation value. See crbug.com/502267

- if (imageLayoutObject->style()->respectImageOrientation() != RespectImageOrientation)

- return true;

+ return true;

}

return false;

@@ -1907,7 +1904,7 @@ void CompositedDeprecatedPaintLayerMapping::updateImageContents()

return;

// This is a no-op if the layer doesn't have an inner layer for the image.

- m_graphicsLayer->setContentsToImage(image);

+ m_graphicsLayer->setContentsToImage(image, imageLayoutObject->shouldRespectImageOrientation());

m_graphicsLayer->setFilterQuality(layoutObject()->style()->imageRendering() == ImageRenderingPixelated ? kNone_SkFilterQuality : kLow_SkFilterQuality);