Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1361393002: Use the latest hash with a commit position as webkit version (Closed)

Created:
5 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the latest hash with a commit position as webkit version This will guarantee that a development build with a not yet commit HEAD will also get a valid devtools frontend from the servers BUG=535268 R=pfeldman@chromium.org,mnaganov@chromium.org,dpranke@chromium.org Committed: https://crrev.com/fb61e3682fe7301373360fa851c7cb3dea9aec1f Cr-Commit-Position: refs/heads/master@{#350565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M build/util/lastchange.py View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
5 years, 3 months ago (2015-09-24 09:02:26 UTC) #1
mnaganov (inactive)
That's exactly what I intended to do, thanks! LGTM.
5 years, 3 months ago (2015-09-24 15:33:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361393002/1
5 years, 3 months ago (2015-09-24 15:46:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-24 15:52:21 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fb61e3682fe7301373360fa851c7cb3dea9aec1f Cr-Commit-Position: refs/heads/master@{#350565}
5 years, 2 months ago (2015-09-24 15:54:33 UTC) #6
Dirk Pranke
5 years, 2 months ago (2015-09-24 18:30:04 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698