Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1361363003: Let LayoutObjects be const to painters (Closed)

Created:
5 years, 2 months ago by Xianzhu
Modified:
5 years, 1 month ago
Reviewers:
chrishtr, pdr.
CC:
darktears, apavlov+blink_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, Rik, danakj, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, f(malita), fs, gasubic, gyuyoung2, jbroman, jchaffraix+rendering, jfernandez, Justin Novosad, kouhei+svg_chromium.org, leviw+renderwatch, mlamouri+watch-blink_chromium.org, pdr+svgwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, philipj_slow, Manuel Rego, rwlbuis, Stephen Chennney, nessy, slimming-paint-reviews_chromium.org, svillar, szager+layoutwatch_chromium.org, vcarbune.chromium, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let LayoutObjects be const to painters Painters should not modify LayoutObject status except some status dedicated for painting. The exceptions are marked mutable. List of 'mutable's added in this CL: - FrameView::m_isPainting: for assertion (in FrameView::layout(), Document::updateLayoutTrees() and FramePainter::paintContents()). Will change to document cycle states. - LayoutObject::BitFields::m_boxDecorationBackgroundState: Lazily updated in LayoutObject::boxDecorationBackgroundIsKnownToBeObscured(). - LayoutTable::m_currentBorder: Used temporarily during painting only. Will move into painter. List of 'const_cast's added in this CL: - ImageQualityController::highQualityRepaintTimerFired() when invalidating LayoutObject on timer. Will change to mutableForPainting[1]. - LineBoxListPainter::paint() This is of const sementics, but LineLayoutBoxModel doesn't support const for now (crbug.com/535785) - SVGFilterPainter::prepareEffect() when calling m_filter.setFilterDataForLayoutObject. TODO(pdr). - ScrollbarPainter::paintIntoRect() a layer violation that the painter changes geometry of scrollbars. There is an existing FIXME. - When calling get() on a Map<non-const-pointer, ...>. - Used to implement const version of getters based on the non-const version. [1] mutableForPainting: https://codereview.chromium.org/1363613002/#msg6 Committed: https://crrev.com/36c3845d2d05a67241376b68cc6e40ab6d4848cb Cr-Commit-Position: refs/heads/master@{#351868}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 9

Patch Set 8 : Rebase #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Total comments: 4

Patch Set 12 : Comments for some existing mutables #

Total comments: 1

Patch Set 13 : link to crbug.com/538236 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1145 lines, -1138 lines) Patch
M third_party/WebKit/Source/core/css/CSSCanvasValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSCanvasValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSCrossfadeValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp View 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSGradientValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSGradientValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageGeneratorValue.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 1 2 3 4 5 6 7 8 9 10 11 6 chunks +12 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAreaElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAreaElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ImageQualityController.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ImageQualityController.cpp View 6 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutDetailsMarker.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutDetailsMarker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFieldset.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFieldset.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFileUploadControl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFileUploadControl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h View 1 3 chunks +27 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 2 3 4 5 6 7 8 9 10 15 chunks +27 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFrameSet.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutHTMLCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutHTMLCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImage.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImage.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListItem.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListItem.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListMarker.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListMarker.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMedia.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMedia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMeter.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 2 3 4 5 6 7 8 9 10 11 6 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPart.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPart.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplica.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplica.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbar.h View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbarTheme.h View 1 2 3 2 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbarTheme.cpp View 5 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.h View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +13 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.h View 1 2 3 3 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 1 2 3 10 chunks +32 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMac.h View 1 2 3 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMac.mm View 1 2 3 10 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutVideo.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutVideo.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/OrderIterator.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/api/LineLayoutBoxModel.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/DeprecatedPaintLayerCompositor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/EllipsisBox.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/EllipsisBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.h View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/RootInlineBox.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGInlineFlowBox.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGInlineFlowBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BackgroundImageGeometry.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BlockFlowPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 1 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.h View 2 chunks +11 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 11 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/paint/DeprecatedPaintLayerClipper.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/DeprecatedPaintLayerClipper.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp View 1 2 3 4 5 6 7 8 9 10 5 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/paint/DetailsMarkerPainter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/EllipsisBoxPainter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/EmbeddedObjectPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FieldsetPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FileUploadControlPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 1 5 chunks +42 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FrameSetPainter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/GridPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/HTMLCanvasPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ImagePainter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp View 1 4 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlinePainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlinePainter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayerClipRecorder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/LineBoxListPainter.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LineBoxListPainter.cpp View 1 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ListItemPainter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ListMarkerPainter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/MediaControlsPainter.h View 1 chunk +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp View 12 chunks +31 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/paint/MultiColumnSetPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/NinePieceImagePainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPainter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PartPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ReplacedPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ReplicaPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/RootInlineBoxPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/RoundedInnerRectClipper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/RoundedInnerRectClipper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGContainerPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGFilterPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGImagePainter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineFlowBoxPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGPaintContext.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGPaintContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGRootInlineBoxPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGRootPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGShapePainter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGTextPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollableAreaPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollbarPainter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollbarPainter.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/TablePainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableRowPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableSectionPainter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableSectionPainter.cpp View 7 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainter.h View 1 chunk +24 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainter.cpp View 1 2 3 12 chunks +23 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterDefault.h View 1 chunk +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp View 19 chunks +73 lines, -73 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterMac.h View 1 2 3 1 chunk +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterMac.mm View 1 2 3 14 chunks +55 lines, -55 lines 0 comments Download
M third_party/WebKit/Source/core/paint/VideoPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ViewPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleGeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StylePendingImage.h View 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Widget.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageLayerChromiumTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.h View 1 2 3 3 chunks +27 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacCommon.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacCommon.mm View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h View 2 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm View 1 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.h View 1 2 3 4 5 1 chunk +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.mm View 1 2 3 4 5 5 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.h View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeNonMacCommon.h View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeNonMacCommon.cpp View 1 2 3 4 5 6 7 8 9 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PageOverlay.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/PageOverlay.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PageOverlayTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (7 generated)
Xianzhu
The CL is big, but I think you can omit the simple places that just ...
5 years, 2 months ago (2015-09-28 20:53:48 UTC) #2
chrishtr
https://codereview.chromium.org/1361363003/diff/120001/third_party/WebKit/Source/core/frame/FrameView.h File third_party/WebKit/Source/core/frame/FrameView.h (right): https://codereview.chromium.org/1361363003/diff/120001/third_party/WebKit/Source/core/frame/FrameView.h#newcode768 third_party/WebKit/Source/core/frame/FrameView.h:768: mutable bool m_isPainting; Which assert? https://codereview.chromium.org/1361363003/diff/120001/third_party/WebKit/Source/core/layout/LayoutObject.h File third_party/WebKit/Source/core/layout/LayoutObject.h (right): ...
5 years, 2 months ago (2015-09-28 22:11:21 UTC) #3
Xianzhu
Updated CL description to make the notes clearer. https://codereview.chromium.org/1361363003/diff/120001/third_party/WebKit/Source/core/frame/FrameView.h File third_party/WebKit/Source/core/frame/FrameView.h (right): https://codereview.chromium.org/1361363003/diff/120001/third_party/WebKit/Source/core/frame/FrameView.h#newcode768 third_party/WebKit/Source/core/frame/FrameView.h:768: mutable ...
5 years, 2 months ago (2015-09-29 00:15:00 UTC) #4
Xianzhu
https://codereview.chromium.org/1361363003/diff/120001/third_party/WebKit/Source/core/frame/FrameView.h File third_party/WebKit/Source/core/frame/FrameView.h (right): https://codereview.chromium.org/1361363003/diff/120001/third_party/WebKit/Source/core/frame/FrameView.h#newcode768 third_party/WebKit/Source/core/frame/FrameView.h:768: mutable bool m_isPainting; On 2015/09/29 00:14:59, Xianzhu wrote: > ...
5 years, 2 months ago (2015-09-29 00:16:14 UTC) #5
Xianzhu
More comments?
5 years, 2 months ago (2015-10-01 16:06:02 UTC) #6
chrishtr
https://codereview.chromium.org/1361363003/diff/200001/third_party/WebKit/Source/core/layout/LayoutTable.h File third_party/WebKit/Source/core/layout/LayoutTable.h (right): https://codereview.chromium.org/1361363003/diff/200001/third_party/WebKit/Source/core/layout/LayoutTable.h#newcode443 third_party/WebKit/Source/core/layout/LayoutTable.h:443: mutable bool m_hasColElements : 1; Please document this https://codereview.chromium.org/1361363003/diff/200001/third_party/WebKit/Source/core/paint/DeprecatedPaintLayerClipper.h ...
5 years, 2 months ago (2015-10-01 16:47:03 UTC) #7
Xianzhu
https://codereview.chromium.org/1361363003/diff/200001/third_party/WebKit/Source/core/layout/LayoutTable.h File third_party/WebKit/Source/core/layout/LayoutTable.h (right): https://codereview.chromium.org/1361363003/diff/200001/third_party/WebKit/Source/core/layout/LayoutTable.h#newcode443 third_party/WebKit/Source/core/layout/LayoutTable.h:443: mutable bool m_hasColElements : 1; On 2015/10/01 16:47:03, chrishtr ...
5 years, 2 months ago (2015-10-01 17:03:16 UTC) #8
chrishtr
lgtm
5 years, 2 months ago (2015-10-01 17:05:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361363003/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361363003/220001
5 years, 2 months ago (2015-10-01 17:07:16 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/90291) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 2 months ago (2015-10-01 17:13:54 UTC) #13
mstensho (USE GERRIT)
https://codereview.chromium.org/1361363003/diff/220001/third_party/WebKit/Source/core/layout/LayoutTable.h File third_party/WebKit/Source/core/layout/LayoutTable.h (right): https://codereview.chromium.org/1361363003/diff/220001/third_party/WebKit/Source/core/layout/LayoutTable.h#newcode443 third_party/WebKit/Source/core/layout/LayoutTable.h:443: // The following mutables are lazily updated in recalcSections() ...
5 years, 2 months ago (2015-10-01 17:23:01 UTC) #14
Xianzhu
On 2015/10/01 17:23:01, mstensho wrote: > https://codereview.chromium.org/1361363003/diff/220001/third_party/WebKit/Source/core/layout/LayoutTable.h > File third_party/WebKit/Source/core/layout/LayoutTable.h (right): > > https://codereview.chromium.org/1361363003/diff/220001/third_party/WebKit/Source/core/layout/LayoutTable.h#newcode443 > ...
5 years, 2 months ago (2015-10-01 17:31:10 UTC) #15
chrishtr
On 2015/10/01 at 17:31:10, wangxianzhu wrote: > On 2015/10/01 17:23:01, mstensho wrote: > > https://codereview.chromium.org/1361363003/diff/220001/third_party/WebKit/Source/core/layout/LayoutTable.h ...
5 years, 2 months ago (2015-10-01 17:33:35 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361363003/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361363003/220001
5 years, 2 months ago (2015-10-01 17:35:06 UTC) #18
Xianzhu
On 2015/10/01 17:33:35, chrishtr wrote: > On 2015/10/01 at 17:31:10, wangxianzhu wrote: > > On ...
5 years, 2 months ago (2015-10-01 18:09:24 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361363003/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361363003/240001
5 years, 2 months ago (2015-10-01 18:11:02 UTC) #23
commit-bot: I haz the power
Committed patchset #13 (id:240001)
5 years, 2 months ago (2015-10-01 20:08:47 UTC) #24
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 20:09:31 UTC) #25
Message was sent while issue was closed.
Patchset 13 (id:??) landed as
https://crrev.com/36c3845d2d05a67241376b68cc6e40ab6d4848cb
Cr-Commit-Position: refs/heads/master@{#351868}

Powered by Google App Engine
This is Rietveld 408576698