Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1361323003: Separate out GN sanitizer flags. (Closed)

Created:
5 years, 2 months ago by brettw
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Separate out GN sanitizer flags. These flags were getting large and out of control, so it's nice to separate them from the generic compiler stuff. Also, this allows us to duplicate the GYP state where the sanitizer flags are not set on the sanitizer options helper code itself. Committed: https://crrev.com/a39fc53cd91687078cc2f3a21518cc0704b96583 Cr-Commit-Position: refs/heads/master@{#351126}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -100 lines) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 1 chunk +0 lines, -100 lines 0 comments Download
M build/config/sanitizers/BUILD.gn View 2 chunks +120 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
brettw
5 years, 2 months ago (2015-09-25 23:12:31 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361323003/20001
5 years, 2 months ago (2015-09-28 16:13:41 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-28 16:48:48 UTC) #8
Dirk Pranke
lgtm
5 years, 2 months ago (2015-09-28 19:11:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361323003/20001
5 years, 2 months ago (2015-09-28 19:35:40 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 19:44:47 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 19:46:26 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a39fc53cd91687078cc2f3a21518cc0704b96583
Cr-Commit-Position: refs/heads/master@{#351126}

Powered by Google App Engine
This is Rietveld 408576698