Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1361323002: Eliminate some clutter in SkFlattenable (Closed)

Created:
5 years, 2 months ago by mdempsky
Modified:
5 years, 2 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Eliminate some clutter in SkFlattenable The Registrar class is unnecessary, as SkFlattenable factory registration is now handled via initialization routines that can just call the Register function directly. Also, no need to lazily initialize gCount to 0, as initializing an int to a constant value does not require dynamic initialization. (C++ actually guarantees zero initialization of global ints anyway, but existing practice in Skia appears to favor the explicit "= 0"). Relatedly, this requires removing the unused/unimplemented SkLayerDrawLooper::MyRegistrar class. And removing that allows Clang to realize that SkLayerDrawLooper::fTopRec is unneeded too, so remove that too to squelch the compiler warning/error. This doesn't change any public API. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/00d6e515e5835f7df6163ceb5f5ceb1770552bf7

Patch Set 1 #

Patch Set 2 : Remove unused SkLayerDrawLooper::fTopRec #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -24 lines) Patch
M include/core/SkFlattenable.h View 2 chunks +2 lines, -9 lines 0 comments Download
M include/effects/SkLayerDrawLooper.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M src/core/SkFlattenable.cpp View 1 chunk +1 line, -8 lines 0 comments Download
M src/effects/SkLayerDrawLooper.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361323002/1
5 years, 2 months ago (2015-09-24 02:07:19 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 2 months ago (2015-09-24 02:07:21 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/3407)
5 years, 2 months ago (2015-09-24 02:08:26 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361323002/20001
5 years, 2 months ago (2015-09-24 03:53:48 UTC) #7
mdempsky
mtklein: PTAL. Technically, SkFlattenable::Registrar was a public class, but it feels to me like it's ...
5 years, 2 months ago (2015-09-24 04:21:30 UTC) #9
commit-bot: I haz the power
Dry run: No LGTM from a valid reviewer yet. Please ask for an LGTM from ...
5 years, 2 months ago (2015-09-24 08:07:00 UTC) #11
mtklein
lgtm Very LGTM. Please do continue to TBR=reed on things like this exactly as you've ...
5 years, 2 months ago (2015-09-24 22:03:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361323002/20001
5 years, 2 months ago (2015-09-24 22:04:10 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-09-24 22:04:49 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/00d6e515e5835f7df6163ceb5f5ceb1770552bf7

Powered by Google App Engine
This is Rietveld 408576698