components/infobars/core/infobar_manager.h - Issue 1361253002: Separate the URL of an infobar link with clicking on it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/infobars/core/infobar_manager.h

Issue 1361253002: Separate the URL of an infobar link with clicking on it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ios Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/infobars/core/confirm_infobar_delegate.h ('K') | « components/infobars/core/confirm_infobar_delegate.cc ('k') | ios/chrome/browser/ui/autofill/autofill_client_ios.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/infobars/core/infobar_manager.h

diff --git a/components/infobars/core/infobar_manager.h b/components/infobars/core/infobar_manager.h

index d984f5bb945e610eb3dbf1b0cc4143ec17f32a3a..1a7c9dbdf34e67760669a7f385b2ba7bff14b37b 100644

--- a/components/infobars/core/infobar_manager.h

+++ b/components/infobars/core/infobar_manager.h

@@ -12,6 +12,7 @@

#include "components/infobars/core/infobar_delegate.h"

class ConfirmInfoBarDelegate;

+class GURL;

namespace content {

class WebContents;

@@ -100,6 +101,9 @@ class InfoBarManager {

virtual scoped_ptr<infobars::InfoBar> CreateConfirmInfoBar(

scoped_ptr<ConfirmInfoBarDelegate> delegate) = 0;

+ // Opens a URL in whatever manner is appropriate.

Peter Kasting 2015/10/01 00:10:58 Nit: in whatever manner is appropriate -> accordin

Avi (use Gerrit) 2015/10/01 00:20:33 Done.

+ virtual void OpenURL(const GURL& url, WindowOpenDisposition disposition) = 0;

protected:

// Notifies the observer in |observer_list_|.

// TODO(droger): Absorb these methods back into their callers once virtual