Separate the URL of an infobar link with clicking on it.

components/infobars/core/confirm_infobar_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_INFOBARS_CORE_CONFIRM_INFOBAR_DELEGATE_H_
 #define COMPONENTS_INFOBARS_CORE_CONFIRM_INFOBAR_DELEGATE_H_
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
 #include "components/infobars/core/infobar_delegate.h"
 #include "components/infobars/core/infobar_manager.h"
+#include "url/gurl.h"
 
 namespace infobars {
 class InfoBar;
 class InfoBarManager;
 }
 
 // An interface derived from InfoBarDelegate implemented by objects wishing to
 // control a ConfirmInfoBar.
 class ConfirmInfoBarDelegate : public infobars::InfoBarDelegate {
  public:
@@ skipping 26 matching lines @@
   // infobar is then immediately closed. Subclasses MUST NOT return true if in
   // handling this call something triggers the infobar to begin closing.
   virtual bool Accept();
 
   // Called when the Cancel button is pressed. If this function returns true,
   // the infobar is then immediately closed. Subclasses MUST NOT return true if
   // in handling this call something triggers the infobar to begin closing.
   virtual bool Cancel();
 
   // Returns the text of the link to be displayed, if any. Otherwise returns
-  // and empty string.
+  // an empty string.
   virtual base::string16 GetLinkText() const;
 
-  // Called when the Link (if any) is clicked. The |disposition| specifies how
-  // the resulting document should be loaded (based on the event flags present
-  // when the link was clicked). If this function returns true, the infobar is
-  // then immediately closed. Subclasses MUST NOT return true if in handling
-  // this call something triggers the infobar to begin closing.
+  // Returns the URL of the link to be displayed.
+  virtual GURL GetLinkURL() const;
+
+  // Called when the link (if any) is clicked; if this function returns true,
+  // the infobar is then immediately closed. The default implementation opens
+  // the URL returned by GetLinkURL(), above, and returns false.
+  //
+  // The |disposition| specifies how the resulting document should be loaded
+  // (based on the event flags present when the link was clicked). Subclasses
+  // MUST NOT return true if in handling this call something triggers the
+  // infobar to begin closing.

[Peter Kasting, 2015/10/01 00:10:58]

Nit: Move this last sentence to end of the previous paragraph?

Maybe add something here about how the default implementation uses a disposition
of NEW_FOREGROUND_TAB if |disposition| is CURRENT_TAB, so that normal clicks on
the link won't automatically blow away the user's page.

[Avi (use Gerrit), 2015/10/01 00:20:33]

Done.
True, though the problem is that it's the InfoBarService that does that
fanciness, not the ConfirmInfoBarDelegate, and I feel weird describing the
function of chrome/ code in comments in components/.

[Peter Kasting, 2015/10/01 00:23:54]

Oh, my mistake.  Put the comment on the InfoBarService method then and here
maybe just note that we pass it on to that function?

[Avi (use Gerrit), 2015/10/01 00:25:38]

My latest patchset puts a comment in InfoBarService. Again, do we comment in
components about a call to a specific function in chrome?

[Peter Kasting, 2015/10/01 01:20:22]

I don't tend to be hard-and-fast about this one, but I think what you have now
is fine.

   virtual bool LinkClicked(WindowOpenDisposition disposition);
 
  protected:
   ConfirmInfoBarDelegate();
 
  private:
   // InfoBarDelegate:
   bool EqualsDelegate(infobars::InfoBarDelegate* delegate) const override;
   ConfirmInfoBarDelegate* AsConfirmInfoBarDelegate() override;
 
   DISALLOW_COPY_AND_ASSIGN(ConfirmInfoBarDelegate);
 };
 
 #endif  // COMPONENTS_INFOBARS_CORE_CONFIRM_INFOBAR_DELEGATE_H_