Separate the URL of an infobar link with clicking on it.

chrome/browser/gpu/three_d_api_observer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gpu/three_d_api_observer.h"
 
 #include "base/metrics/histogram.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/tab_contents/tab_util.h"
 #include "chrome/grit/generated_resources.h"
@@ skipping 28 matching lines @@
 
   // ConfirmInfoBarDelegate:
   int GetIconId() const override;
   bool EqualsDelegate(infobars::InfoBarDelegate* delegate) const override;
   ThreeDAPIInfoBarDelegate* AsThreeDAPIInfoBarDelegate() override;
   base::string16 GetMessageText() const override;
   base::string16 GetButtonLabel(InfoBarButton button) const override;
   bool Accept() override;
   bool Cancel() override;
   base::string16 GetLinkText() const override;
-  bool LinkClicked(WindowOpenDisposition disposition) override;
+  GURL GetLinkURL() const override;
 
   GURL url_;
   content::ThreeDAPIType requester_;
   // Basically indicates whether the infobar was displayed at all, or
   // was a temporary instance thrown away by the InfobarService.
   mutable bool message_text_queried_;
   bool action_taken_;
 
   DISALLOW_COPY_AND_ASSIGN(ThreeDAPIInfoBarDelegate);
 };
@@ skipping 82 matching lines @@
   content::GpuDataManager::GetInstance()->UnblockDomainFrom3DAPIs(url_);
   InfoBarService::WebContentsFromInfoBar(infobar())->GetController().Reload(
       true);
   return true;
 }
 
 base::string16 ThreeDAPIInfoBarDelegate::GetLinkText() const {
   return l10n_util::GetStringUTF16(IDS_LEARN_MORE);
 }
 
-bool ThreeDAPIInfoBarDelegate::LinkClicked(WindowOpenDisposition disposition) {
-  InfoBarService::WebContentsFromInfoBar(infobar())->OpenURL(
-      content::OpenURLParams(
-          GURL("https://support.google.com/chrome/?p=ib_webgl"),
-          content::Referrer(),
-          (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
-          ui::PAGE_TRANSITION_LINK, false));
-  return false;
+GURL ThreeDAPIInfoBarDelegate::GetLinkURL() const {
+  return GURL("https://support.google.com/chrome/?p=ib_webgl");
 }
 
-

[Peter Kasting, 2015/10/01 00:10:58]

Nit: Leave this blank line

[Avi (use Gerrit), 2015/10/01 00:20:33]

Done.

 // ThreeDAPIObserver ----------------------------------------------------------
 
 ThreeDAPIObserver::ThreeDAPIObserver() {
   content::GpuDataManager::GetInstance()->AddObserver(this);
 }
 
 ThreeDAPIObserver::~ThreeDAPIObserver() {
   content::GpuDataManager::GetInstance()->RemoveObserver(this);
 }
 
 void ThreeDAPIObserver::DidBlock3DAPIs(const GURL& top_origin_url,
                                        int render_process_id,
                                        int render_frame_id,
                                        content::ThreeDAPIType requester) {
   content::WebContents* web_contents = tab_util::GetWebContentsByFrameID(
       render_process_id, render_frame_id);
   if (!web_contents)
     return;
   ThreeDAPIInfoBarDelegate::Create(
       InfoBarService::FromWebContents(web_contents), top_origin_url, requester);
 }