Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: runtime/vm/debugger.cc

Issue 1361213003: Distinguish internal kill messages from user-initiated kill messages. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/isolate.h » ('j') | runtime/vm/raw_object.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc
index 6ec2bbd2df14fdde21b5b34f699b6114a040c1aa..27b18381b42b26df0cf495d7397ecfed3129ba71 100644
--- a/runtime/vm/debugger.cc
+++ b/runtime/vm/debugger.cc
@@ -15,6 +15,7 @@
#include "vm/globals.h"
#include "vm/longjump.h"
#include "vm/json_stream.h"
+#include "vm/message_handler.h"
#include "vm/object.h"
#include "vm/object_store.h"
#include "vm/os.h"
@@ -349,7 +350,11 @@ RawError* Debugger::SignalIsolateInterrupted() {
OS::Print("[!] Embedder api: terminating isolate:\n"
"\tisolate: %s\n", isolate_->name());
}
- const String& msg = String::Handle(String::New("isolate terminated"));
+ // TODO(turnidge): We should give the message handler a way to
+ // detect when an isolate is unwinding.
+ isolate_->message_handler()->set_pause_on_exit(false);
+ const String& msg =
+ String::Handle(String::New("isolate terminated by embedder"));
return UnwindError::New(msg);
}
}
« no previous file with comments | « no previous file | runtime/vm/isolate.h » ('j') | runtime/vm/raw_object.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698