Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1361203002: Omit commit position for Blink lastchange / version (Closed)

Created:
5 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, pfeldman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M build/util/lastchange.py View 6 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
jochen (gone - plz use gerrit)
5 years, 3 months ago (2015-09-23 20:05:45 UTC) #1
jochen (gone - plz use gerrit)
wdyt, running tryjobs to see whether it fixes the browser tests
5 years, 3 months ago (2015-09-23 20:06:14 UTC) #2
pfeldman
Why are there two modes?
5 years, 3 months ago (2015-09-23 20:06:56 UTC) #3
jochen (gone - plz use gerrit)
On 2015/09/23 at 20:06:56, pfeldman wrote: > Why are there two modes? i want to ...
5 years, 3 months ago (2015-09-23 20:10:35 UTC) #4
pfeldman
lgtm
5 years, 3 months ago (2015-09-23 20:17:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361203002/1
5 years, 3 months ago (2015-09-23 20:20:33 UTC) #7
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-23 20:38:28 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f880f0071d47ec1aa9608245222ad0b6f350e48c Cr-Commit-Position: refs/heads/master@{#350370}
5 years, 3 months ago (2015-09-23 21:09:05 UTC) #9
jochen (gone - plz use gerrit)
5 years, 3 months ago (2015-09-23 21:09:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f880f0071d47ec1aa9608245222ad0b6f350e48c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698