Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1361173005: Created SerializedUserDataManager. (Closed)

Created:
5 years, 3 months ago by kkhorimoto
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@serialized_navigation_manager
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Created SerializedUserDataManager. This class allows for clients of web/ to associate arbitrary data with a browsing session that will be persisted with the NavigationManager. BUG=454984

Patch Set 1 #

Total comments: 21

Patch Set 2 : Eugene's comments #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -1 line) Patch
M ios/web/ios_web.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M ios/web/navigation/crw_serialized_navigation_manager.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/navigation/crw_serialized_navigation_manager.mm View 1 4 chunks +19 lines, -0 lines 1 comment Download
M ios/web/navigation/serialized_navigation_manager_builder.mm View 1 3 chunks +12 lines, -0 lines 0 comments Download
A ios/web/navigation/serialized_user_data_manager_impl.h View 1 1 chunk +35 lines, -0 lines 0 comments Download
A ios/web/navigation/serialized_user_data_manager_impl.mm View 1 1 chunk +97 lines, -0 lines 0 comments Download
M ios/web/public/browser_url_rewriter.h View 1 chunk +2 lines, -0 lines 0 comments Download
A ios/web/public/serialized_user_data_manager.h View 1 1 chunk +57 lines, -0 lines 1 comment Download
M ios/web/web_state/web_state_impl.mm View 1 2 chunks +13 lines, -1 line 1 comment Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
kkhorimoto
https://codereview.chromium.org/1361173005/diff/1/ios/web/public/browser_url_rewriter.h File ios/web/public/browser_url_rewriter.h (right): https://codereview.chromium.org/1361173005/diff/1/ios/web/public/browser_url_rewriter.h#newcode8 ios/web/public/browser_url_rewriter.h:8: #include <vector> Not sure why, but my changes in ...
5 years, 3 months ago (2015-09-24 00:55:48 UTC) #2
Eugene But (OOO till 7-30)
https://codereview.chromium.org/1361173005/diff/1/ios/web/navigation/crw_serialized_navigation_manager.h File ios/web/navigation/crw_serialized_navigation_manager.h (right): https://codereview.chromium.org/1361173005/diff/1/ios/web/navigation/crw_serialized_navigation_manager.h#newcode37 ios/web/navigation/crw_serialized_navigation_manager.h:37: // Dictionary of arbitrary serialized data added using NIT: ...
5 years, 3 months ago (2015-09-24 17:05:07 UTC) #3
kkhorimoto
https://codereview.chromium.org/1361173005/diff/1/ios/web/navigation/crw_serialized_navigation_manager.h File ios/web/navigation/crw_serialized_navigation_manager.h (right): https://codereview.chromium.org/1361173005/diff/1/ios/web/navigation/crw_serialized_navigation_manager.h#newcode37 ios/web/navigation/crw_serialized_navigation_manager.h:37: // Dictionary of arbitrary serialized data added using On ...
5 years, 3 months ago (2015-09-24 21:24:29 UTC) #4
Eugene But (OOO till 7-30)
5 years, 3 months ago (2015-09-24 21:39:25 UTC) #5
https://codereview.chromium.org/1361173005/diff/20001/ios/web/navigation/crw_...
File ios/web/navigation/crw_serialized_navigation_manager.mm (right):

https://codereview.chromium.org/1361173005/diff/20001/ios/web/navigation/crw_...
ios/web/navigation/crw_serialized_navigation_manager.mm:121: return
_serializedUserData;
NIT: Maybe return an autoreleased copy here (same as in
GetSerializationDictionary)?

https://codereview.chromium.org/1361173005/diff/20001/ios/web/public/serializ...
File ios/web/public/serialized_user_data_manager.h (right):

https://codereview.chromium.org/1361173005/diff/20001/ios/web/public/serializ...
ios/web/public/serialized_user_data_manager.h:55: }
NIT: // namespace web

https://codereview.chromium.org/1361173005/diff/20001/ios/web/web_state/web_s...
File ios/web/web_state/web_state_impl.mm (right):

https://codereview.chromium.org/1361173005/diff/20001/ios/web/web_state/web_s...
ios/web/web_state/web_state_impl.mm:115: WebStateImpl* non_const_this =
const_cast<WebStateImpl*>(this);
This is a violation of API contract. This method promises to be const, but it
changes WebState.

Powered by Google App Engine
This is Rietveld 408576698