[GN]: Add asmflags

[GN]: Add asmflags

+ Also, don’t specify a PCH as a dependency for a build rule that doesn't support PCH.

BUG=418613
Committed: https://crrev.com/40fc4844e1a0dd91378044911fd2df573447369d
Cr-Commit-Position: refs/heads/master@{#350654}

[Bons, 2015-09-23 21:51:59]

andybons@chromium.org changed reviewers:
+ brettw@chromium.org, dpranke@chromium.org

[Bons, 2015-09-23 21:53:31]

On 2015/09/23 21:52:00, Bons wrote:

Diff out/Default/obj/base/base.ninja against
https://gist.github.com/andybons/38e428bface194aed955 to see the difference in
output.

[Bons, 2015-09-24 17:49:50]

On 2015/09/23 21:53:31, Bons wrote:
> On 2015/09/23 21:52:00, Bons wrote:
> 
> Diff out/Default/obj/base/base.ninja against
> https://gist.github.com/andybons/38e428bface194aed955 to see the difference in
> output.

gentle ping

[brettw, 2015-09-24 18:30:09]

https://codereview.chromium.org/1361173004/diff/1/tools/gn/ninja_binary_targe...
File tools/gn/ninja_binary_target_writer.cc (left):

https://codereview.chromium.org/1361173004/diff/1/tools/gn/ninja_binary_targe...
tools/gn/ninja_binary_target_writer.cc:427: used_types.Get(SOURCE_S) ||
used_types.Get(SOURCE_ASM)) {
Can you leave the S/ASM check in here and below with a TODO to remove? In
between the time that we roll these GN binary deps and the time we update the
toolchain definition to use asmflags, we won't necessarily write cflags for
targets that have only assembly files. Once we start using asmflags, we can
remove these lines.

https://codereview.chromium.org/1361173004/diff/1/tools/gn/variables.cc
File tools/gn/variables.cc (right):

https://codereview.chromium.org/1361173004/diff/1/tools/gn/variables.cc#newco...
tools/gn/variables.cc:398: "asmflags|cflags*: Flags passed to the C compiler.\n"
I find this weird. Can you make a separate entry for asmflags rather than trying
to shared this string?

[Bons, 2015-09-24 19:41:54]

https://codereview.chromium.org/1361173004/diff/1/tools/gn/ninja_binary_targe...
File tools/gn/ninja_binary_target_writer.cc (left):

https://codereview.chromium.org/1361173004/diff/1/tools/gn/ninja_binary_targe...
tools/gn/ninja_binary_target_writer.cc:427: used_types.Get(SOURCE_S) ||
used_types.Get(SOURCE_ASM)) {
On 2015/09/24 18:30:09, brettw wrote:
> Can you leave the S/ASM check in here and below with a TODO to remove? In
> between the time that we roll these GN binary deps and the time we update the
> toolchain definition to use asmflags, we won't necessarily write cflags for
> targets that have only assembly files. Once we start using asmflags, we can
> remove these lines.

Done.

https://codereview.chromium.org/1361173004/diff/1/tools/gn/variables.cc
File tools/gn/variables.cc (right):

https://codereview.chromium.org/1361173004/diff/1/tools/gn/variables.cc#newco...
tools/gn/variables.cc:398: "asmflags|cflags*: Flags passed to the C compiler.\n"
On 2015/09/24 18:30:09, brettw wrote:
> I find this weird. Can you make a separate entry for asmflags rather than
trying
> to shared this string?

Done.

[brettw, 2015-09-24 19:52:51]

lgtm

[Bons, 2015-09-24 19:53:21]

The CQ bit was checked by andybons@chromium.org

[commit-bot: I haz the power, 2015-09-24 19:56:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361173004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361173004/20001

[commit-bot: I haz the power, 2015-09-24 20:42:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-24 20:43:31]

Patchset 2 (id:??) landed as
https://crrev.com/40fc4844e1a0dd91378044911fd2df573447369d
Cr-Commit-Position: refs/heads/master@{#350654}