Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1361143004: EDK: Add a mojo::test::SimpleTestThread (and use it). (Closed)

Created:
5 years, 2 months ago by viettrungluu
Modified:
5 years, 2 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Add a mojo::test::SimpleTestThread (and use it). This replaces (direct) uses of base::SimpleThread. (Currently, its implemented on top of base::SimpleThread, but that's easy enough to replace.) R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/de1a2abe32ba3c26db31570db387305c9c0fe39c

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -32 lines) Patch
M mojo/edk/system/channel_manager_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M mojo/edk/system/dispatcher_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher_unittest.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M mojo/edk/system/waiter_test_utils.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/waiter_test_utils.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/edk/system/waiter_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/edk/test/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A mojo/edk/test/simple_test_thread.h View 1 chunk +40 lines, -0 lines 2 comments Download
A mojo/edk/test/simple_test_thread.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
5 years, 2 months ago (2015-09-23 20:40:31 UTC) #1
vardhan
lgtm https://codereview.chromium.org/1361143004/diff/1/mojo/edk/test/simple_test_thread.h File mojo/edk/test/simple_test_thread.h (right): https://codereview.chromium.org/1361143004/diff/1/mojo/edk/test/simple_test_thread.h#newcode26 mojo/edk/test/simple_test_thread.h:26: // Note: Subclasses must implement: Could this note ...
5 years, 2 months ago (2015-09-23 23:36:22 UTC) #2
viettrungluu
https://codereview.chromium.org/1361143004/diff/1/mojo/edk/test/simple_test_thread.h File mojo/edk/test/simple_test_thread.h (right): https://codereview.chromium.org/1361143004/diff/1/mojo/edk/test/simple_test_thread.h#newcode26 mojo/edk/test/simple_test_thread.h:26: // Note: Subclasses must implement: On 2015/09/23 23:36:22, vardhan ...
5 years, 2 months ago (2015-09-23 23:37:13 UTC) #3
viettrungluu
5 years, 2 months ago (2015-09-23 23:37:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
de1a2abe32ba3c26db31570db387305c9c0fe39c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698