Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 136113019: Cleanup: Remove some unused code, or make them platform specific. (Closed)

Created:
6 years, 10 months ago by Lei Zhang
Modified:
6 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews, vsevik, James Su, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, markusheintz_, aandrey+blink_chromium.org, pfeldman
Visibility:
Public.

Description

Cleanup: Remove some unused code, or make them platform specific. Found by Scythe. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248465

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -50 lines) Patch
M chrome/browser/autocomplete/autocomplete_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_controller.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_file_system_helper.h View 1 chunk +1 line, -11 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_file_system_helper.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_detector_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/chrome_browser_main.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chrome_net_benchmarking_message_filter.h View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chrome_net_benchmarking_message_filter.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/devtools/devtools_adb_bridge.cc View 4 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Lei Zhang
dead code must die
6 years, 10 months ago (2014-01-29 03:26:45 UTC) #1
Nico
lgtm! https://codereview.chromium.org/136113019/diff/20001/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/136113019/diff/20001/chrome/browser/chrome_browser_main.cc#newcode524 chrome/browser/chrome_browser_main.cc:524: // TODO(port) This should be used on Linux ...
6 years, 10 months ago (2014-01-29 03:35:15 UTC) #2
Lei Zhang
https://codereview.chromium.org/136113019/diff/20001/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/136113019/diff/20001/chrome/browser/chrome_browser_main.cc#newcode524 chrome/browser/chrome_browser_main.cc:524: // TODO(port) This should be used on Linux Aura ...
6 years, 10 months ago (2014-01-29 03:45:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/136113019/40001
6 years, 10 months ago (2014-01-29 22:30:00 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=218287
6 years, 10 months ago (2014-01-29 23:04:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/136113019/80001
6 years, 10 months ago (2014-01-29 23:22:53 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_perf_unittests, telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=253898
6 years, 10 months ago (2014-01-30 00:47:14 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-03 08:21:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/136113019/80001
6 years, 10 months ago (2014-02-03 08:21:34 UTC) #9
commit-bot: I haz the power
Change committed as 248465
6 years, 10 months ago (2014-02-03 10:00:48 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 10:00:55 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 10:00:57 UTC) #12
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698