Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 136113007: Mark next_code_link as weak in heap profiler. (Closed)

Created:
6 years, 11 months ago by alph
Modified:
6 years, 10 months ago
Reviewers:
ulan, yurys
CC:
v8-dev
Visibility:
Public.

Description

Mark next_code_link as weak in heap profiler. LOG=N R=ulan@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18907

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M src/heap-snapshot-generator.cc View 3 chunks +11 lines, -7 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +9 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
alph
ptal
6 years, 11 months ago (2014-01-27 15:41:28 UTC) #1
yurys
lgtm https://codereview.chromium.org/136113007/diff/1/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right): https://codereview.chromium.org/136113007/diff/1/test/cctest/test-heap-profiler.cc#newcode350 test/cctest/test-heap-profiler.cc:350: GetProperty(compiled_code, v8::HeapGraphEdge::kInternal, "code"); Can we force presence of ...
6 years, 11 months ago (2014-01-27 15:50:57 UTC) #2
ulan
lgtm
6 years, 11 months ago (2014-01-27 15:52:03 UTC) #3
alph
https://codereview.chromium.org/136113007/diff/1/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right): https://codereview.chromium.org/136113007/diff/1/test/cctest/test-heap-profiler.cc#newcode350 test/cctest/test-heap-profiler.cc:350: GetProperty(compiled_code, v8::HeapGraphEdge::kInternal, "code"); On 2014/01/27 15:50:57, yurys wrote: > ...
6 years, 10 months ago (2014-01-29 13:41:32 UTC) #4
alph
6 years, 10 months ago (2014-01-29 13:45:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r18907 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698