Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Issue 136113006: Increase default stack size on Android with ASan to 2Mb. (Closed)

Created:
6 years, 11 months ago by eugenis
Modified:
6 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Increase default stack size on Android with ASan to 2Mb. BUG=263749, 325685 TEST=cc_unittests on ASan/Android bot R=glider@chromium.org, thakis@chromium.org, bulach@chromium.org, navabi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247670

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M base/threading/platform_thread_android.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
eugenis
6 years, 11 months ago (2014-01-27 14:52:38 UTC) #1
Alexander Potapenko
LGTM https://codereview.chromium.org/136113006/diff/1/base/threading/platform_thread_android.cc File base/threading/platform_thread_android.cc (right): https://codereview.chromium.org/136113006/diff/1/base/threading/platform_thread_android.cc#newcode103 base/threading/platform_thread_android.cc:103: return 2 * (1 << 20); // 2Mb ...
6 years, 11 months ago (2014-01-27 14:54:50 UTC) #2
eugenis
https://codereview.chromium.org/136113006/diff/1/base/threading/platform_thread_android.cc File base/threading/platform_thread_android.cc (right): https://codereview.chromium.org/136113006/diff/1/base/threading/platform_thread_android.cc#newcode103 base/threading/platform_thread_android.cc:103: return 2 * (1 << 20); // 2Mb On ...
6 years, 11 months ago (2014-01-27 15:14:29 UTC) #3
eugenis
6 years, 10 months ago (2014-01-28 14:27:19 UTC) #4
Nico
(since you're adding people, you're probably looking for someone to review? If you add additional ...
6 years, 10 months ago (2014-01-28 16:12:58 UTC) #5
Nico
lgtm
6 years, 10 months ago (2014-01-28 16:13:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eugenis@chromium.org/136113006/60001
6 years, 10 months ago (2014-01-29 09:16:12 UTC) #7
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=144050
6 years, 10 months ago (2014-01-29 10:23:27 UTC) #8
eugenis
6 years, 10 months ago (2014-01-29 11:15:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r247670 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698