Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: src/interpreter/bytecode-array-iterator.h

Issue 1361113002: [Interpreter] Add support for loading globals in the interpreter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix BytecodeArrayBuilderTest Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecode-array-iterator.h
diff --git a/src/interpreter/bytecode-array-iterator.h b/src/interpreter/bytecode-array-iterator.h
index a0de3f0e7737e24436cf69aae83548c086ff2beb..6392e21feb3f3121f48738c91a0e000608052a0f 100644
--- a/src/interpreter/bytecode-array-iterator.h
+++ b/src/interpreter/bytecode-array-iterator.h
@@ -29,9 +29,9 @@ class BytecodeArrayIterator {
Register GetRegisterOperand(int operand_index) const;
Handle<Object> GetConstantForIndexOperand(int operand_index) const;
- private:
- uint8_t GetOperand(int operand_index, OperandType operand_type) const;
+ uint8_t GetRawOperand(int operand_index) const;
Michael Starzinger 2015/09/24 08:54:54 nit: IIUC this is only exposed for testing. Can we
rmcilroy 2015/09/24 11:20:12 Changed to add an OperandType and add checking as
+ private:
Handle<BytecodeArray> bytecode_array_;
int bytecode_offset_;

Powered by Google App Engine
This is Rietveld 408576698