Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1361073002: Common up eager handling of sweeping. (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Common up eager handling of sweeping. Code tidying, no change in functionality. R=haraken BUG= Committed: https://crrev.com/3b3efc02da6f8e8b3f8b94325762b087f8ce2677 Cr-Commit-Position: refs/heads/master@{#350644}

Patch Set 1 #

Patch Set 2 : rebased to new repo #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
sof
please take a look.
5 years, 3 months ago (2015-09-23 08:45:18 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-09-23 08:51:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361073002/1
5 years, 3 months ago (2015-09-23 15:59:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_dbg/builds/63606) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-23 16:03:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361073002/40001
5 years, 3 months ago (2015-09-24 17:59:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/45068)
5 years, 3 months ago (2015-09-24 18:18:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361073002/40001
5 years, 3 months ago (2015-09-24 19:39:02 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-24 20:21:05 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 20:22:11 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3b3efc02da6f8e8b3f8b94325762b087f8ce2677
Cr-Commit-Position: refs/heads/master@{#350644}

Powered by Google App Engine
This is Rietveld 408576698