Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1361043003: Revert of Make 2D canvas smarter about chosing whether or not to use GPU acceleration (Closed)

Created:
5 years, 3 months ago by Justin Novosad
Modified:
5 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make 2D canvas smarter about chosing whether or not to use GPU acceleration (patchset #2 id:20001 of https://codereview.chromium.org/1367683002/ ) Reason for revert: Patch has test failures Original issue's description: > Make 2D canvas smarter about chosing whether or not to use GPU acceleration > > The CL takes advantage of the fact that canvas rendering is deferred > to defer the decision of whether or not a canvas should be > GPU-accelerated. The decision is made based on the conditions > under which a canvas is flushed for the first time. For example, > if the purpose of the first flush is to perform a readback, then > GPU-acceleration will be disabled for the canvas in order to avoid > reading GPU memory into RAM, which is known to be a slow path. > > BUG=265849 > TBR=senorblanco@chromium.org, kbr@chromium.org > NOTRY=true > > Committed: https://crrev.com/9ac9c385c8f55f826c42e1f3a56cf66600b9e934 > Cr-Commit-Position: refs/heads/master@{#350655} TBR=kbr@chromium.org,senorblanco@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=265849 Committed: https://crrev.com/e8cac159f27bb9a24eca106cdea07abdf421f29c Cr-Commit-Position: refs/heads/master@{#350673}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -403 lines) Patch
M third_party/WebKit/Source/core/css/CSSCanvasValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.h View 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 8 chunks +7 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasImageSource.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 4 chunks +5 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 14 chunks +28 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DImageBufferSurface.h View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h View 5 chunks +4 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 21 chunks +59 lines, -130 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 10 chunks +38 lines, -145 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsTypes.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 4 chunks +15 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBufferSurface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Justin Novosad
Created Revert of Make 2D canvas smarter about chosing whether or not to use GPU ...
5 years, 3 months ago (2015-09-24 21:38:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361043003/1
5 years, 3 months ago (2015-09-24 21:39:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 21:41:37 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 21:42:23 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8cac159f27bb9a24eca106cdea07abdf421f29c
Cr-Commit-Position: refs/heads/master@{#350673}

Powered by Google App Engine
This is Rietveld 408576698