Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: ios/web/navigation/navigation_manager_impl.h

Issue 1360993002: Moved NavigationManagerImpl serialization out of CRWSessionController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/navigation/navigation_manager_impl.h
diff --git a/ios/web/navigation/navigation_manager_impl.h b/ios/web/navigation/navigation_manager_impl.h
index 63479acf40384e831675454b85d4acac8936fef5..9fda8310c5c7f1778351a3f22ccdf725469777fe 100644
--- a/ios/web/navigation/navigation_manager_impl.h
+++ b/ios/web/navigation/navigation_manager_impl.h
@@ -24,15 +24,19 @@ class NavigationItem;
struct Referrer;
class NavigationManagerDelegate;
class NavigationManagerFacadeDelegate;
+class NavigationManagerSerializationBuilder;
// Implementation of NavigationManager.
// Generally mirrors upstream's NavigationController.
class NavigationManagerImpl : public NavigationManager {
public:
- NavigationManagerImpl(NavigationManagerDelegate* delegate,
- BrowserState* browser_state);
+ NavigationManagerImpl();
~NavigationManagerImpl() override;
+ // Setters for NavigationManagerDelegate and BrowserState.
+ void SetDelegate(NavigationManagerDelegate* delegate);
+ void SetBrowserState(BrowserState* browser_state);
+
// Sets the CRWSessionController that backs this object.
// Keeps a strong reference to |session_controller|.
// This method should only be called when deserializing |session_controller|
@@ -138,6 +142,10 @@ class NavigationManagerImpl : public NavigationManager {
int GetIndexForOffset(int offset) const;
private:
+ // The NavigationManagerSerializationBuilder functions require access to
+ // private variables of NavigationManagerImpl.
+ friend NavigationManagerSerializationBuilder;
+
// Returns true if the PageTransition for the underlying navigation item at
// |index| has ui::PAGE_TRANSITION_IS_REDIRECT_MASK.
bool IsRedirectItemAtIndex(int index) const;

Powered by Google App Engine
This is Rietveld 408576698