Moved NavigationManagerImpl serialization out of CRWSessionController.

ios/web/navigation/crw_serialized_navigation_manager.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_WEB_NAVIGATION_CRW_SERIALIZED_NAVIGATION_MANAGER_H_
+#define IOS_WEB_NAVIGATION_CRW_SERIALIZED_NAVIGATION_MANAGER_H_
+
+#import <Foundation/Foundation.h>
+
+@class CRWSessionCertificatePolicyManager;
+@class XCallbackParameters;
+
+namespace web {
+class NavigationManagerImpl;
+}
+
+@interface CRWSerializedNavigationManager : NSObject<NSCoding>

[Eugene But (OOO till 7-30), 2015/09/23 16:33:44]

class needs comments

[Eugene But (OOO till 7-30), 2015/09/23 16:33:44]

This is not actually a manager. Maybe CRWNavigationStorage ?

[kkhorimoto, 2015/09/24 18:12:59]

I added the comment, but left the name the same.  The name is meant as "a
serialized NavigationManager", whereas you're reading it as "the manager of
serialized navigations".  This matches the naming convention upstream for
SerializedNavigationEntry.

[Eugene But (OOO till 7-30), 2015/09/24 18:44:29]

SerializedNavigationEntry is unambiguous name. But many people will still read
CRWSerializedNavigationManager as "the manager of serialized navigations". I'm
strongly in favor for not using Manager suffix for storage classes, and can
suggest something like CRWNavigationManagerData. I think that strategy to match
content naming pattern *sometimes* leads to misleading naming. Stuart will be in
a position to make a decision on this.

[stuartmorgan, 2015/09/28 22:27:33]

I think Eugene's point is a good one. For instance, there's a
SerializedNavigationBuilder elsewhere in the codebase which is in fact a builder
of serialized navigations, rather than a serialization of navigation builders. I
think just Data loses some of the clarity of its purpose though; how about
CRWNavigationManagerSerialization?

+
+// Properties taken from NavigationManagerImpl and CRWSessionController.
+@property(nonatomic, copy) NSString* tabId;

[Eugene But (OOO till 7-30), 2015/09/23 16:33:44]

s/tabId/tabID

[kkhorimoto, 2015/09/24 18:12:59]

Done.

+@property(nonatomic, copy) NSString* openerId;

[Eugene But (OOO till 7-30), 2015/09/23 16:33:43]

openerID

[kkhorimoto, 2015/09/24 18:12:59]

Done.

+@property(nonatomic, getter=isOpenedByDOM) BOOL openedByDOM;
+@property(nonatomic, assign) NSInteger openerNavigationIndex;
+@property(nonatomic, copy) NSString* windowName;
+@property(nonatomic, assign) NSInteger currentNavigationIndex;
+@property(nonatomic, assign) NSInteger previousNavigationIndex;
+@property(nonatomic, assign) NSTimeInterval lastVisitedTimestamp;
+// TODO(kkhorimoto): |entries| currently contains CRWSessionEntries.  Once
+// NavigationItemImpls are encoded/decoded using CRWSerializedNavigationItems
+// (analogous to the approach taken with NavigationManagerImpl), this will
+// become an array of CRWSerializedNavigationItems.
+@property(nonatomic, copy) NSArray* entries;
+@property(nonatomic, retain)
+    CRWSessionCertificatePolicyManager* sessionCertificatePolicyManager;
+@property(nonatomic, retain) XCallbackParameters* xCallbackParameters;

[Eugene But (OOO till 7-30), 2015/09/23 16:33:44]

s/xCallbackParameters/XCallbackParameters

[kkhorimoto, 2015/09/24 18:12:59]

Done.

+
+@end
+
+#endif  // IOS_WEB_NAVIGATION_CRW_SERIALIZED_NAVIGATION_MANAGER_H_