Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 1360953003: [runtime] Remove weird pushing of something on StackOverflow. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove weird pushing of something on StackOverflow. We somehow try to push some stuff on the stack when we detect a stack overflow, that we don't need. Even worse we might access outside the valid stack bounds. Since we don't need this, it's gone. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg,v8_linux_nosnap_dbg R=jarin@chromium.org BUG=chromium:534881 LOG=n Committed: https://crrev.com/556b522ac62414c87d05f5d6bab33f6b6cab9b13 Cr-Commit-Position: refs/heads/master@{#30883}

Patch Set 1 #

Patch Set 2 : Fix test failures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -87 lines) Patch
M src/arm/builtins-arm.cc View 5 chunks +4 lines, -14 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 5 chunks +4 lines, -19 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 5 chunks +3 lines, -13 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 5 chunks +4 lines, -14 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 5 chunks +4 lines, -14 lines 0 comments Download
M src/x64/builtins-x64.cc View 5 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Benedikt Meurer
5 years, 3 months ago (2015-09-23 08:25:00 UTC) #1
Benedikt Meurer
Hey Jaro, Quick one to remove dead code. Please take a look. Thanks, Benedikt
5 years, 3 months ago (2015-09-23 08:25:40 UTC) #2
Jarin
lgtm
5 years, 3 months ago (2015-09-23 08:34:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360953003/1
5 years, 3 months ago (2015-09-23 08:44:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/4893)
5 years, 3 months ago (2015-09-23 08:52:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360953003/20001
5 years, 3 months ago (2015-09-23 09:41:35 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-23 10:58:42 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 10:58:59 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/556b522ac62414c87d05f5d6bab33f6b6cab9b13
Cr-Commit-Position: refs/heads/master@{#30883}

Powered by Google App Engine
This is Rietveld 408576698