Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1360943004: Revert of Use a class instead of several separate globals in crash_logging.cc. (Closed)

Created:
5 years, 2 months ago by zhaoqin1
Modified:
5 years, 2 months ago
Reviewers:
danakj, Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use a class instead of several separate globals in crash_logging.cc. (patchset #3 id:60001 of https://codereview.chromium.org/1368703002/ ) Reason for revert: This CL is the culprit of an uninit read and several test crash on Valgrind bots. BUG=535990 Original issue's description: > Use a class instead of several separate globals in crash_logging.cc. > > There should be no behavior change; this is just refactoring. > > Committed: https://crrev.com/5e57bcecf023ec05c9c2343b2b636f3d7e0cf1f1 > Cr-Commit-Position: refs/heads/master@{#350701} TBR=danakj@chromium.org,rsesek@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/957cf8cf24209ccb63c59ee7cdddbb07aeaab386 Cr-Commit-Position: refs/heads/master@{#350829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -136 lines) Patch
M base/debug/crash_logging.h View 1 chunk +3 lines, -0 lines 0 comments Download
M base/debug/crash_logging.cc View 4 chunks +78 lines, -124 lines 0 comments Download
M base/debug/crash_logging_unittest.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/common/crash_keys_unittest.cc View 3 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zhaoqin1
Created Revert of Use a class instead of several separate globals in crash_logging.cc.
5 years, 2 months ago (2015-09-25 15:14:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360943004/1
5 years, 2 months ago (2015-09-25 15:14:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 15:16:15 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 15:17:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/957cf8cf24209ccb63c59ee7cdddbb07aeaab386
Cr-Commit-Position: refs/heads/master@{#350829}

Powered by Google App Engine
This is Rietveld 408576698