Chromium Code Reviews Chromium Code Reviews
Issue
1360943003:
simplify code in SkRecords.h (Closed)
Descriptionsimplify code in SkRecords.h
- use C++11 features ({} init, move constructors) to eliminate the need
for explicit constructors
- collapse RECORD0...RECORD8 into just one RECORD macro
- explicitly tag record types instead of using member detectors.
Removing member detectors makes this code significantly less fragile.
This exposes a few places where we didn't really think through what to do
with SkDrawable. I've marked them TODO for now.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/449d9b7e2d1b2e20963f18639c6e541ef953f069
Patch Set 1 #Patch Set 2 : undef RECORD #Patch Set 3 : tags #Patch Set 4 : fmt #Patch Set 5 : replace member detectors #Patch Set 6 : simplify #Patch Set 7 : DrawAtlas has an atlas... #Patch Set 8 : fix SaveLayer #Patch Set 9 : !!? #Patch Set 10 : another SaveLayer #
Messages
Total messages: 18 (8 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
